relatorio: Fixes for Python3.4

COLLABORATORS=cedric.krier@b2ck.com

[ced, 2014-07-08 19:01:00]

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/__ini...
File relatorio/templates/__init__.py (right):

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/__ini...
relatorio/templates/__init__.py:34: warnings.warn(msg)
Why?

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/_comp...
File relatorio/templates/_compat.py (right):

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/_comp...
relatorio/templates/_compat.py:7: from StringIO import StringIO as BytesIO
StringIO is not the same as BytesIO

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/chart.py
File relatorio/templates/chart.py (right):

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/chart...
relatorio/templates/chart.py:68: yml =
BytesIO(_encode(self.text_serializer(stream)))
Why using BytesIO, yaml is string.

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/opend...
File relatorio/templates/opendocument.py (right):

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/opend...
relatorio/templates/opendocument.py:110: if isinstance(val, str):
Useless.

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/opend...
relatorio/templates/opendocument.py:360: if sys.version_info < (3,):
Useless.

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/opend...
relatorio/templates/opendocument.py:510: table_namespace))
Useless

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/pdf.py
File relatorio/templates/pdf.py (right):

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/pdf.p...
relatorio/templates/pdf.py:63: pdf = BytesIO()
Indeed it should always be BytesIO

https://codereview.appspot.com/104580046/diff/20001/relatorio/tests/test_api.py
File relatorio/tests/test_api.py (right):

https://codereview.appspot.com/104580046/diff/20001/relatorio/tests/test_api....
relatorio/tests/test_api.py:32: for key, val in kwargs.items():
Useless.

https://codereview.appspot.com/104580046/diff/20001/relatorio/tests/test_odt.py
File relatorio/tests/test_odt.py (right):

https://codereview.appspot.com/104580046/diff/20001/relatorio/tests/test_odt....
relatorio/tests/test_odt.py:49: if sys.version_info < (3,):
Existing version works.

https://codereview.appspot.com/104580046/diff/20001/relatorio/tests/test_odt....
relatorio/tests/test_odt.py:51: return buffer(str(stream, 'utf-8'))
Don'T understand

https://codereview.appspot.com/104580046/diff/20001/relatorio/tests/test_odt....
relatorio/tests/test_odt.py:63: self.oot = Template(fp)
Don't understand

https://codereview.appspot.com/104580046/diff/20001/relatorio/tests/test_odt....
relatorio/tests/test_odt.py:282: tree = lxml.etree.parse(BytesIO(r))
xml is String.

[ced, 2014-07-16 14:23:35]

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/pdf.py
File relatorio/templates/pdf.py (right):

https://codereview.appspot.com/104580046/diff/20001/relatorio/templates/pdf.p...
relatorio/templates/pdf.py:63: pdf = BytesIO()
On 2014/07/08 19:00:59, ced wrote:
> Indeed it should always be BytesIO

But could you create a new issue with the error message.

[yangoon, 2014-07-16 15:54:25]

There are some comments with 'Useless', 'Don't understand' and 'Existing version
works.', that indeed seem to be caused by Python3.4 (as on Debian). So I am
postponing this codereview, until you will have available Python3.4 to see, if
you will see those errors, too.

[ced, 2014-12-21 21:46:37]

On 2014/07/16 15:54:25, yangoon wrote:
> There are some comments with 'Useless', 'Don't understand' and 'Existing
version
> works.', that indeed seem to be caused by Python3.4 (as on Debian). So I am
> postponing this codereview, until you will have available Python3.4 to see, if
> you will see those errors, too.

I tested with python 3.4 and it works out of the box.