Use minified frame JS in tests.

Previously, all test drivers always configured caja.js with
'debug: true', which disables using minified source files. Therefore,
the minified files are never exercised. While our minifier for those
does not do identifier renaming like Closure does to caja.js and is
therefore not as hazardous, we should still be testing what we expect
to be deployed.

* In test drivers, set caja config option 'debug' (which currently
  controls only minification) to the negation of the 'minified' URL
  parameter.
* For test drivers which do nothing special in this area,
  browser-test-case.js now provieds 'basicCajaConfig' which gives
  cajaServer, debug, and forceES5Mode appropriate values.
* Fix a pattern match in es53-test-scan-guest to be compatible with
  minified code.

See <https://code.google.com/p/google-caja/issues/detail?id=1774>.

@r5458

[ihab.awad, 2013-06-21 18:22:24]

lgtm++ -- comments and questions should not block checkin.

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/b...
File tests/com/google/caja/plugin/browser-test-case.js (right):

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/b...
tests/com/google/caja/plugin/browser-test-case.js:119: *     setUp, tearDown,
Missing @provides basicCajaConfig?

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js (right):

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:86: forceES5Mode:
inES5Mode
This is same as basicCajaConfig....

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js
(right):

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js:69:
caja.initialize({
Copy basicCajaConfig and add to it?

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-scan-guest.js (right):

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-scan-guest.js:169: /defProp\(this, ?name,
?\{/.exec(String(desc.set)) ||
A little confused about how this pattern matches minified code; why just adding
the "?"?

[kpreid2, 2013-06-21 21:25:29]

Previously, all test drivers always configured caja.js with
'debug: true', which disables using minified source files. Therefore,
the minified files are never exercised. While our minifier for those
does not do identifier renaming like Closure does to caja.js and is
therefore not as hazardous, we should still be testing what we expect
to be deployed.

* In test drivers, set caja config option 'debug' (which currently
  controls only minification) to the negation of the 'minified' URL
  parameter.
* For test drivers which do nothing special in this area,
  browser-test-case.js now provieds 'basicCajaConfig' which gives
  cajaServer, debug, and forceES5Mode appropriate values.
* Fix a pattern match in es53-test-scan-guest to be compatible with
  minified code.

See <https://code.google.com/p/google-caja/issues/detail?id=1774>.

[kpreid2, 2013-06-21 21:26:28]

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/b...
File tests/com/google/caja/plugin/browser-test-case.js (right):

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/b...
tests/com/google/caja/plugin/browser-test-case.js:119: *     setUp, tearDown,
On 2013/06/21 18:22:24, ihab.awad wrote:
> Missing @provides basicCajaConfig?

Done.

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js (right):

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:86: forceES5Mode:
inES5Mode
On 2013/06/21 18:22:24, ihab.awad wrote:
> This is same as basicCajaConfig....

Done, everywhere in this file.

Originally I left this alone because I thought this file had several different
caja configs, but now I see they don't actually need to be different. (I assume
the lack of forceES5Mode in testReinitialization is unnecessary.)

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:91:
getUrlParam('minified', 'PARAM MISSING'),
Changed this to use minifiedMode.

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js
(right):

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js:69:
caja.initialize({
On 2013/06/21 18:22:24, ihab.awad wrote:
> Copy basicCajaConfig and add to it?

Eh, there's not a great way to do that — there's no basic “copy a record”
operation. I didn't want to clutter the code with reflective fiddling.

Should we arrange to have something like that?

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-scan-guest.js (right):

https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-scan-guest.js:169: /defProp\(this, ?name,
?\{/.exec(String(desc.set)) ||
On 2013/06/21 18:22:24, ihab.awad wrote:
> A little confused about how this pattern matches minified code; why
> just adding the "?"?

The only thing the minifier does to this code is remove whitespace, so I'm
making whitespace optional in the pattern.

[ihab.awad, 2013-06-21 21:50:17]

lgtm as-is, no need to add more :)