Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 10447046: In ES5 mode, emit rewritten CSS inside the guest document. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by kpreid2
Modified:
12 years, 8 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In ES5 mode, or document.write content in ES5/3 mode: * <style> elements in the guest document contain rewritten CSS rather than being empty. * <link rel=stylesheet> elements' rewritten CSS goes into <style> elements inserted immediately before them. This is unfortunately visible to the guest, but I expect to be unlikely to be noticed. * <link> elements get normal element processing rather than being discarded after having stylesheet-loading side effects. This is preparation for being able to use an iframed document as a vdoc container, where there is no enclosing document to create style elements in. @r5459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -47 lines) Patch
M src/com/google/caja/plugin/html-emitter.js View 8 chunks +44 lines, -21 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-client-uri-rewriting.js View 6 chunks +35 lines, -14 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 4 chunks +26 lines, -11 lines 0 comments Download
M tests/com/google/caja/plugin/third-party-tests.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
kpreid2
12 years, 8 months ago (2013-06-21 17:24:47 UTC) #1
felix8a
12 years, 8 months ago (2013-06-24 18:18:42 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b