code review 104200047: runtime: stack allocator, separate from mallocgc

src/pkg/runtime/proc.c

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 #include "runtime.h"
 #include "arch_GOARCH.h"
 #include "zaexperiment.h"
 #include "malloc.h"
 #include "stack.h"
 #include "race.h"
@@ skipping 1904 matching lines @@
 
         if(gp->stackguard - StackGuard != gp->stack0)
                 runtime·throw("invalid stack in gfput");
         stksize = gp->stackbase + sizeof(Stktop) - gp->stack0;
         if(stksize != gp->stacksize) {
                 runtime·printf("runtime: bad stacksize, goroutine %D, remain=%d, last=%d\n",
                         gp->goid, (int32)gp->stacksize, (int32)stksize);
                 runtime·throw("gfput: bad stacksize");
         }
         top = (Stktop*)gp->stackbase;
-        if(top->malloced) {
+        if(stksize != StackMin) {
                 // non-standard stack size - free it.
                 runtime·stackfree(gp, (void*)gp->stack0, top);
                 gp->stack0 = 0;
                 gp->stackguard = 0;
                 gp->stackguard0 = 0;
                 gp->stackbase = 0;
         }
         gp->schedlink = p->gfree;
         p->gfree = gp;
         p->gfreecnt++;
@@ skipping 496 matching lines @@
         acquirep(p);
         for(i = new-1; i > 0; i--) {
                 p = runtime·allp[i];
                 p->status = Pidle;
                 pidleput(p);
         }
         runtime·atomicstore((uint32*)&runtime·gomaxprocs, new);
 }
 
 // Associate p and the current m.
+#pragma textflag NOSPLIT
 static void
 acquirep(P *p)
 {
         if(m->p || m->mcache)
                 runtime·throw("acquirep: already in go");
         if(p->m || p->status != Pidle) {
-                runtime·printf("acquirep: p->m=%p(%d) p->status=%d\n", p->m, p->m ? p->m->id : 0, p->status);
+                //runtime·printf("acquirep: p->m=%p(%d) p->status=%d\n", p->m, p->m ? p->m->id : 0, p->status);
                 runtime·throw("acquirep: invalid p state");
         }
         m->mcache = p->mcache;
         m->p = p;
         p->m = m;
         p->status = Prunning;
 }
 
 // Disassociate p and the current m.
 static P*
@@ skipping 675 matching lines @@
                                 if(experiment[i+j] != name[j])
                                         goto nomatch;
                         if(experiment[i+j] != '\0' && experiment[i+j] != ',')
                                 goto nomatch;
                         return 1;
                 }
         nomatch:;
         }
         return 0;
 }