Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1709)

Issue 104200044: oauth2: add appengine and appengine managed vm service account implementations

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by jbd
Modified:
10 years, 10 months ago
Reviewers:
adg
Visibility:
Public.

Description

In this case, godoc doesn't document anything.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Adding docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -0 lines) Patch
A google/appengine.go View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A google/appenginevm.go View 1 2 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jbd
10 years, 10 months ago (2014-06-17 14:11:14 UTC) #1
adg
https://codereview.appspot.com/104200044/diff/1/google/appenginevm.go File google/appenginevm.go (right): https://codereview.appspot.com/104200044/diff/1/google/appenginevm.go#newcode1 google/appenginevm.go:1: // +build appenginevm I think this should just be ...
10 years, 10 months ago (2014-06-20 16:41:20 UTC) #2
jbd
Oh, sorry. That was obvious. It's working with godoc now :)
10 years, 10 months ago (2014-06-20 21:46:05 UTC) #3
adg
LGTM
10 years, 10 months ago (2014-06-20 22:11:28 UTC) #4
jbd
10 years, 10 months ago (2014-06-22 21:41:57 UTC) #5
Submitted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b