Issue 104081: allow reviewers to edit issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 104081: allow reviewers to edit issues

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 5 months ago by russcox

Modified:
16 years, 5 months ago

Reviewers:
GvR

Base URL:
http://rietveld.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This patch allows reviewers to edit and close issues. Note that self.owner is a string but self.reviewers is a list of unicode strings. I didn't attempt to resolve that inconsistency. I have tested this on a local SDK instance.

Patch Set 1 #

Created: 16 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	codereview/models.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

russcox_gmail.com

re http://code.google.com/p/rietveld/issues/detail?id=142

16 years, 5 months ago (2009-08-11 19:36:38 UTC) #1

GvR

16 years, 5 months ago (2009-08-12 16:42:45 UTC) #2

Alas, this has a gaping hole -- it turns out (and I forgot) that anyone can add
themselves (or anyone else) to any issue.

For example, if you go to http://codereview.appspot.com/25073/publish you'll see
yourself added to the reviewer list...

Expand All Messages | Collapse All Messages