Better fix for redirects on media download.

Better fix for redirects on media download. Uses the native redirect following of httplib2.

[bossylobster, 2013-06-19 00:47:31]

https://codereview.appspot.com/10393046/diff/1/apiclient/http.py
File apiclient/http.py (right):

https://codereview.appspot.com/10393046/diff/1/apiclient/http.py#newcode553
apiclient/http.py:553: if 'content-location' in resp and
resp['content-location'] != self._uri:
Why wouldn't this be associated with a 302? Did you mean to add 302 to [200,
206]?

Also, you should use a tuple for this list and likely make it a constant
somewhere.

[yarbrough, 2013-06-19 00:49:43]

https://codereview.appspot.com/10393046/diff/1/tests/test_http.py
File tests/test_http.py (right):

https://codereview.appspot.com/10393046/diff/1/tests/test_http.py#newcode372
tests/test_http.py:372: ({'status': '200',
I think this should still be a 307.

[jcgregorio_google, 2013-06-19 13:55:10]

https://codereview.appspot.com/10393046/diff/1/apiclient/http.py
File apiclient/http.py (right):

https://codereview.appspot.com/10393046/diff/1/apiclient/http.py#newcode553
apiclient/http.py:553: if 'content-location' in resp and
resp['content-location'] != self._uri:
No, this is not on a 302. Read:

  http://httplib2.googlecode.com/hg/doc/html/libhttplib2.html#response-objects

The httplib2 library will follow redirects automatically
and set the 'content-location' to the final URL that it got after following the
redirects. It will also return the status code of the final URL, which in this
case is a 200 or 206.



On 2013/06/19 00:47:31, bossylobster wrote:
> Why wouldn't this be associated with a 302? Did you mean to add 302 to [200,
> 206]?
> 
> Also, you should use a tuple for this list and likely make it a constant
> somewhere.

[dhermes, 2013-06-19 15:26:42]

LGTM, unless yarbrough has some remaining feedback (which he did)

[yarbrough, 2013-06-19 16:40:31]

Ah, I see. Nevermind, LGTM!

[jcgregorio_google, 2013-06-19 17:25:43]

On 2013/06/19 16:40:31, yarbrough wrote:
> Ah, I see. Nevermind, LGTM!

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=1ab344e0a3...