https://codereview.appspot.com/103910044/diff/1/findbugs-exclude.xml File findbugs-exclude.xml (right): https://codereview.appspot.com/103910044/diff/1/findbugs-exclude.xml#newcode73 findbugs-exclude.xml:73: <And> Is there a way to exclude this check ...
11 years, 6 months ago
(2014-06-04 22:19:30 UTC)
#2
Replied to question. https://codereview.appspot.com/103910044/diff/1/findbugs-exclude.xml File findbugs-exclude.xml (right): https://codereview.appspot.com/103910044/diff/1/findbugs-exclude.xml#newcode73 findbugs-exclude.xml:73: <And> On 2014/06/04 22:19:30, wonderfly wrote: ...
11 years, 6 months ago
(2014-06-05 17:16:28 UTC)
#3
Replied to question.
https://codereview.appspot.com/103910044/diff/1/findbugs-exclude.xml
File findbugs-exclude.xml (right):
https://codereview.appspot.com/103910044/diff/1/findbugs-exclude.xml#newcode73
findbugs-exclude.xml:73: <And>
On 2014/06/04 22:19:30, wonderfly wrote:
> Is there a way to exclude this check for all classes/methods?
Yes, we could probably shut off the rule completely.
I think excluding it off at the class or method level has some merit. If we
write any new code, this may help avoid this performance issue. But for a
locked-down library like this there is little value in clearing out the backlog
because it is just risk for little gain.
Issue 103910044: Exclude findbugs failing tests.
(Closed)
Created 11 years, 6 months ago by Anthony Moore
Modified 11 years, 6 months ago
Reviewers: wonderfly
Base URL: https://code.google.com/p/google-api-java-client/
Comments: 2