Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(196)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 10382043: Updated AdSense Management API samples to V1.3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by jalc
Modified:
12 years, 1 month ago
Reviewers:
jcgregorio_google
CC:
sgomes_google, google-api-python-client_googlegroups.com
Base URL:
https://code.google.com/p/google-api-python-client/
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removing unnecessary argument handling lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -28 lines) Patch
M samples/adsense/generate_report.py View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/adsense/generate_report_with_paging.py View 1 chunk +1 line, -1 line 0 comments Download
M samples/adsense/get_account_tree.py View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/adsense/get_all_accounts.py View 1 chunk +1 line, -1 line 0 comments Download
M samples/adsense/get_all_ad_clients.py View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/adsense/get_all_ad_clients_for_account.py View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/adsense/get_all_ad_units.py View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/adsense/get_all_ad_units_for_custom_channel.py View 3 chunks +3 lines, -3 lines 0 comments Download
A samples/adsense/get_all_alerts.py View 1 1 chunk +55 lines, -0 lines 0 comments Download
M samples/adsense/get_all_custom_channels.py View 3 chunks +4 lines, -4 lines 0 comments Download
M samples/adsense/get_all_custom_channels_for_ad_unit.py View 3 chunks +2 lines, -4 lines 0 comments Download
A samples/adsense/get_all_dimensions.py View 1 1 chunk +55 lines, -0 lines 0 comments Download
A samples/adsense/get_all_metrics.py View 1 1 chunk +55 lines, -0 lines 0 comments Download
M samples/adsense/get_all_saved_ad_styles.py View 1 chunk +1 line, -1 line 0 comments Download
M samples/adsense/get_all_saved_reports.py View 1 chunk +1 line, -1 line 0 comments Download
M samples/adsense/get_all_url_channels.py View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4
jalc
12 years, 1 month ago (2013-06-18 10:04:24 UTC) #1
jcgregorio_google
https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_alerts.py File samples/adsense/get_all_alerts.py (right): https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_alerts.py#newcode31 samples/adsense/get_all_alerts.py:31: argparser = argparse.ArgumentParser(add_help=False) If there are no flags then ...
12 years, 1 month ago (2013-06-18 18:50:01 UTC) #2
jalc
Done! https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_alerts.py File samples/adsense/get_all_alerts.py (right): https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_alerts.py#newcode31 samples/adsense/get_all_alerts.py:31: argparser = argparse.ArgumentParser(add_help=False) On 2013/06/18 18:50:02, jcgregorio_google wrote: ...
12 years, 1 month ago (2013-06-19 09:29:30 UTC) #3
jcgregorio_google
12 years, 1 month ago (2013-06-19 13:54:03 UTC) #4 
On 2013/06/19 09:29:30, jalc wrote:
> Done!
> 
>
https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_alerts.py
> File samples/adsense/get_all_alerts.py (right):
> 
>
https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_alerts...
> samples/adsense/get_all_alerts.py:31: argparser =
> argparse.ArgumentParser(add_help=False)
> On 2013/06/18 18:50:02, jcgregorio_google wrote:
> > If there are no flags then you can drop these two lines.
> 
> Done.
> 
>
https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_dimens...
> File samples/adsense/get_all_dimensions.py (right):
> 
>
https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_dimens...
> samples/adsense/get_all_dimensions.py:31: argparser =
> argparse.ArgumentParser(add_help=False)
> On 2013/06/18 18:50:02, jcgregorio_google wrote:
> > Can be removed.
> 
> Done.
> 
>
https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_metric...
> File samples/adsense/get_all_metrics.py (right):
> 
>
https://codereview.appspot.com/10382043/diff/1/samples/adsense/get_all_metric...
> samples/adsense/get_all_metrics.py:31: argparser =
> argparse.ArgumentParser(add_help=False)
> On 2013/06/18 18:50:02, jcgregorio_google wrote:
> > Remove these two lines.
> 
> Done.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b