Issue 103770044: apiserver/admin: fix incorrect (down) status

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 103770044: apiserver/admin: fix incorrect (down) status

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by wwitzel

Modified:
10 years, 10 months ago

Reviewers:
mp+221724, hduran

Visibility:
Public.

Description

apiserver/admin: fix incorrect (down) status use WaitAgentPresence to prevent reporting the agent status as (down) for the duration of the period in the state/presence loop. This resolves the an issue with incorrect reporting in juju status and the wrong number of state machines being created by juju ensure-availability. https://code.launchpad.net/~wwitzel3/juju-core/010-bootstrap-ensure/+merge/221724 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : apiserver/admin: fix incorrect (down) status #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -70 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/ensureavailability_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/status_test.go	View		4 chunks	+10 lines, -10 lines	0 comments	Download
M	state/addmachine.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/admin.go	View	1	4 chunks	+12 lines, -3 lines	0 comments	Download
M	state/apiserver/client/api_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/client/client_test.go	View		8 chunks	+14 lines, -14 lines	0 comments	Download
M	state/apiserver/client/status.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/apiserver/server_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/machine.go	View		2 chunks	+8 lines, -7 lines	0 comments	Download
M	state/machine_test.go	View		3 chunks	+11 lines, -11 lines	0 comments	Download
M	state/unit.go	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	state/unit_test.go	View		2 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages