Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(133)

Issue 103760043: code review 103760043: [release-branch.go1.3] remove package debug/goobj and c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by adg
Modified:
10 years, 4 months ago
Reviewers:
rsc, bradfitz
CC:
golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] remove package debug/goobj and copy functionality to cmd/nm

Patch Set 1 #

Patch Set 2 : diff -r ab87321471ae https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+680 lines, -703 lines) Patch
A src/cmd/nm/debug_goobj.go View 1 chunk +670 lines, -0 lines 0 comments Download
M src/cmd/nm/goobj.go View 2 chunks +10 lines, -11 lines 0 comments Download
R src/pkg/debug/goobj/read.go View 1 1 chunk +0 lines, -664 lines 0 comments Download
R src/pkg/debug/goobj/read_test.go View 1 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 3
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2014-06-02 02:21:20 UTC) #1
bradfitz
LGTM On Mon, Jun 2, 2014 at 11:21 AM, <adg@golang.org> wrote: > Reviewers: rsc, > ...
10 years, 4 months ago (2014-06-02 02:24:37 UTC) #2
adg
10 years, 4 months ago (2014-06-02 03:35:09 UTC) #3

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b