Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 10373044: separate test results (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by felix8a
Modified:
12 years, 8 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

right now, we generate a test report in the same directory we save test logs, which is inconvenient because the test summary is an index.html file, making it difficult to use a webbrowser to look at other files in that directory. this change: 1. moves the test report out of ant-reports/test.runtests into a separate dir report.runtests 2. moves captured screenshots etc out of test.runtests into capture.runtests

Patch Set 1 #

Total comments: 2

Patch Set 2 : separate test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M build.xml View 1 8 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 6
felix8a
12 years, 8 months ago (2013-06-18 22:04:43 UTC) #1
kpreid2
https://codereview.appspot.com/10373044/diff/1/build.xml File build.xml (right): https://codereview.appspot.com/10373044/diff/1/build.xml#newcode321 build.xml:321: <mkdir dir="${reports}/capture.${test.type}" /> I don't like this cartesian-product naming ...
12 years, 8 months ago (2013-06-18 22:35:05 UTC) #2
felix8a
right now, we generate a test report in the same directory we save test logs, ...
12 years, 8 months ago (2013-06-18 23:28:40 UTC) #3
felix8a
new snapshot https://codereview.appspot.com/10373044/diff/1/build.xml File build.xml (right): https://codereview.appspot.com/10373044/diff/1/build.xml#newcode321 build.xml:321: <mkdir dir="${reports}/capture.${test.type}" /> On 2013/06/18 22:35:05, kpreid2 ...
12 years, 8 months ago (2013-06-18 23:29:00 UTC) #4
kpreid2
LGTM
12 years, 8 months ago (2013-06-18 23:31:59 UTC) #5
felix8a
12 years, 8 months ago (2013-06-18 23:41:25 UTC) #6
@r5454
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b