Issue 103670044: Add ibus reset-config and read-config sub-commands.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 103670044: Add ibus reset-config and read-config sub-commands. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by fujiwara

Modified:
9 years, 10 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Add ibus reset-config and read-config sub-commands. BUG=rhbz#530711 TEST=tools/ibus

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Updated with the latest master. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -1 line)			Patch
	M	tools/main.vala	View	1	4 chunks	+47 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/103670044/diff/1/tools/main.vala File tools/main.vala (right): https://codereview.appspot.com/103670044/diff/1/tools/main.vala#newcode315 tools/main.vala:315: break; https://developer.gnome.org/glib/stable/glib-GVariant.html#g-variant-print-string What about using g_variant_print_string()?

9 years, 10 months ago (2014-07-02 14:35:38 UTC) #2

fujiwara

https://codereview.appspot.com/103670044/diff/1/tools/main.vala File tools/main.vala (right): https://codereview.appspot.com/103670044/diff/1/tools/main.vala#newcode315 tools/main.vala:315: break; On 2014/07/02 14:35:38, Peng wrote: > https://developer.gnome.org/glib/stable/glib-GVariant.html#g-variant-print-string > ...

9 years, 10 months ago (2014-07-03 07:14:26 UTC) #3

lgtm

Expand All Messages | Collapse All Messages