Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1129)

Issue 103620043: LIB Fix b/15114347: Better error message for invalid GSA hostname. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Brett
Modified:
9 years, 11 months ago
Reviewers:
pjo
CC:
connector-cr_google.com
Visibility:
Public.

Description

This change provides a more descriptive error message in the log if the configured GSA is not found at startup.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Better messages for GSA communication issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M src/com/google/enterprise/adaptor/GsaCommunicationHandler.java View 1 4 chunks +26 lines, -1 line 0 comments Download
M src/com/google/enterprise/adaptor/GsaFeedFileSender.java View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7
Brett
9 years, 11 months ago (2014-06-26 23:05:50 UTC) #1
pjo
Thank you. https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/adaptor/Application.java File src/com/google/enterprise/adaptor/Application.java (right): https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/adaptor/Application.java#newcode154 src/com/google/enterprise/adaptor/Application.java:154: } catch (UnknownHostException ex) { What throws ...
9 years, 11 months ago (2014-06-27 01:34:53 UTC) #2
Brett
https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/adaptor/Application.java File src/com/google/enterprise/adaptor/Application.java (right): https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/adaptor/Application.java#newcode154 src/com/google/enterprise/adaptor/Application.java:154: } catch (UnknownHostException ex) { On 2014/06/27 01:34:53, pjo ...
9 years, 11 months ago (2014-06-27 22:33:42 UTC) #3
pjo
Thank you for your nuanced considerations. https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/adaptor/Application.java File src/com/google/enterprise/adaptor/Application.java (right): https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/adaptor/Application.java#newcode154 src/com/google/enterprise/adaptor/Application.java:154: } catch (UnknownHostException ...
9 years, 11 months ago (2014-06-27 23:08:00 UTC) #4
Brett
Better messages for GSA communication issues.
9 years, 11 months ago (2014-06-28 02:37:55 UTC) #5
pjo
LGTM. Thank you.
9 years, 11 months ago (2014-06-28 02:42:07 UTC) #6
Brett
9 years, 11 months ago (2014-06-28 03:34:12 UTC) #7
Committed 27 June 2014 to Adaptor Library:

To https://code.google.com/p/plexi/
   6451260..6037ba5  master -> master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b