Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(296)

Issue 10347044: downgrade css identifier error from FATAL to WARNING (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by felix8a
Modified:
12 years, 9 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

for some reason, a CSS selector like "input:-moz-placeholder" is a fatal error in es53, and it aborts processing. I don't see a reason for this to be a fatal eror, so I'm downgrading it to a warning. It's safe to do that because the warning still marks that css rule as invalid, and it gets removed later.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/com/google/caja/plugin/PluginMessageType.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 9 months ago (2013-06-17 20:54:42 UTC) #1
ihab.awad
lgtm
12 years, 9 months ago (2013-06-17 20:58:11 UTC) #2
felix8a
12 years, 9 months ago (2013-06-18 04:22:53 UTC) #3
@r5452
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b