code review 10345046: cmd/ld: handle duplicate static symbols in COFF files.

src/cmd/ld/ldmacho.c

 /*
 Derived from Plan 9 from User Space's src/libmach/elf.h, elf.c
 http://code.swtch.com/plan9port/src/tip/src/libmach/
 
         Copyright © 2004 Russ Cox.
         Portions Copyright © 2008-2010 Google Inc.
         Portions Copyright © 2010 The Go Authors.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ skipping 593 matching lines @@
                 if(sym->type&N_STAB)
                         continue;
                 // TODO: check sym->type against outer->type.
                 name = sym->name;
                 if(name[0] == '_' && name[1] != '\0')
                         name++;
                 v = 0;
                 if(!(sym->type&N_EXT))
                         v = version;
                 s = lookup(name, v);
+                if(!(sym->type&N_EXT))
+                        s->dupok = 1;
                 sym->sym = s;
                 if(sym->sectnum == 0)   // undefined
                         continue;
                 if(sym->sectnum > c->seg.nsect) {
                         werrstr("reference to invalid section %d", sym->sectnum);
                         goto bad;
                 }
                 sect = &c->seg.sect[sym->sectnum-1];
                 outer = sect->sym;
                 if(outer == nil) {
@@ skipping 221 matching lines @@
                 }·······················
                 qsort(r, rp - r, sizeof r[0], rbyoff);
                 s->r = r;
                 s->nr = rp - r;
         }
         return;
 
 bad:
         diag("%s: malformed mach-o file: %r", pn);
 }