code review 103450043: syscall: regenerate z-files for linux

syscall: regenerate z-files for linux

Updates z-files from 3.2 kernel-based to 3.14 kernel-based.

Update issue 6677

[mikio, 2014-06-20 08:47:04]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-06-20 13:42:18]

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/mkerrors.sh
File src/pkg/syscall/mkerrors.sh (left):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/mkerrors...
src/pkg/syscall/mkerrors.sh:121: #ifndef MSG_FASTOPEN
Why are you dropping the MSG_FASTOPEN test?  It seems to me that we should keep
it even if it is not necessary with your kernel version.

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/mkerrors.sh
File src/pkg/syscall/mkerrors.sh (right):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/mkerrors...
src/pkg/syscall/mkerrors.sh:93: #include <termios.h>
In the future, please do this kind of rearrangement of header files in a
separate CL.  It doesn't have anything to do with updating Linux kernel
versions.

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
File src/pkg/syscall/types_linux.go (left):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:35: #include <sys/resource.h>
Why have you changed from <sys/resource.h> to <linux/resource.h>?

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:385: VINTR    = C.VINTR
Why are these all going away?

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
File src/pkg/syscall/types_linux.go (right):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:124: struct non__glibc_reserved_stat
Why do this?  It kind of misses the point of this general procedure, which is to
pick up the structs from the header files.

At the very least something like this needs a comment.

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:458: type InotifyEvent
C.struct_changeset_b5b8898c7002_inotify_event
This also looks wrong and needs an explanation.

[mikio, 2014-06-27 01:36:34]

ptal

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/mkerrors.sh
File src/pkg/syscall/mkerrors.sh (left):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/mkerrors...
src/pkg/syscall/mkerrors.sh:121: #ifndef MSG_FASTOPEN
restored

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/mkerrors.sh
File src/pkg/syscall/mkerrors.sh (right):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/mkerrors...
src/pkg/syscall/mkerrors.sh:93: #include <termios.h>
si

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
File src/pkg/syscall/types_linux.go (left):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:35: #include <sys/resource.h>
see golang.org/issue/6677, simply cmd/cgo+godefs cannot handle well the union of
c, and linux guys modified rusage in {sys,bits}/resource.h to make use of union.

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:385: VINTR    = C.VINTR
now mkerrors.sh can pick up all of them with the latest linux kernel headers.
perhaps bits/termios.h has been reorganized between 3.2 and 3.14.

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
File src/pkg/syscall/types_linux.go (right):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:124: struct non__glibc_reserved_stat
sorry it's a dreg, removed.

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:458: type InotifyEvent
C.struct_changeset_b5b8898c7002_inotify_event
added a comment

[iant, 2014-06-28 00:36:08]

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
File src/pkg/syscall/types_linux.go (left):

https://codereview.appspot.com/103450043/diff/380002/src/pkg/syscall/types_li...
src/pkg/syscall/types_linux.go:35: #include <sys/resource.h>
On 2014/06/27 01:36:34, mikio wrote:
> see golang.org/issue/6677, simply cmd/cgo+godefs cannot handle well the union
of
> c, and linux guys modified rusage in {sys,bits}/resource.h to make use of
union.

Please see if https://codereview.appspot.com/106260044 fixes this problem.

[mikio, 2014-07-30 01:14:17]

*** Abandoned ***