Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1991)

Issue 10340045: [Custom]: Change to use custom element type, rather than custom element name. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Dimitri Glazkov
Modified:
10 years, 10 months ago
Reviewers:
dominicc-chromium
Visibility:
Public.

Description

[Custom]: Change to use custom element type, rather than custom element name.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M spec/custom/index.html View 19 chunks +27 lines, -26 lines 3 comments Download

Messages

Total messages: 2
dominicc-chromium
LGTM with one suggestion inline, at your discretion. https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html File spec/custom/index.html (right): https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html#newcode371 spec/custom/index.html:371: <li>Let ...
10 years, 10 months ago (2013-06-18 00:30:31 UTC) #1
Dimitri Glazkov
10 years, 10 months ago (2013-06-18 17:04:58 UTC) #2
https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html
File spec/custom/index.html (right):

https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html#newcode696
spec/custom/index.html:696: <li>Let <var>DECLARATION</var> be a <a
href="#dfn-custom-element-declaration">custom element declaration</a> with <a
href="#dfn-custom-element-type">custom element type</a> set to <var>NAME</var>,
<a href="#dfn-base-element-name">base element name</a> to <var>BASE</var>, <a
href="#dfn-constructor-name">constructor name</a> to <var>CONSTRUCTOR</var>, and
<a href="#dfn-declaration-property-bag">declaration property bag</a> to
<var>PROPERTIES</var></li>
On 2013/06/18 00:30:31, dominicc-chromium wrote:
> I feel like the renaming should happen earlier, on line 687:
> 
> Let TYPE be the value of ELEMENT's name attribute, converted to lowercase.
> 
> etc.

Great idea! Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b