LGTM with one suggestion inline, at your discretion. https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html File spec/custom/index.html (right): https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html#newcode371 spec/custom/index.html:371: <li>Let ...
11 years, 7 months ago
(2013-06-18 00:30:31 UTC)
#1
LGTM with one suggestion inline, at your discretion.
https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html
File spec/custom/index.html (right):
https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html#newcode371
spec/custom/index.html:371: <li>Let <var>ERROR</var> be the result of running
the <a href="#dfn-element-registration-algorithm">element registration
algorithm</a> with <var>CONTEXT</var>, <var>TYPE</var>, <var>PROTOTYPE</var>,
and <var>NAME</var> as arguments</li>
Woohoo! This is much more readable.
https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html#newcode696
spec/custom/index.html:696: <li>Let <var>DECLARATION</var> be a <a
href="#dfn-custom-element-declaration">custom element declaration</a> with <a
href="#dfn-custom-element-type">custom element type</a> set to <var>NAME</var>,
<a href="#dfn-base-element-name">base element name</a> to <var>BASE</var>, <a
href="#dfn-constructor-name">constructor name</a> to <var>CONSTRUCTOR</var>, and
<a href="#dfn-declaration-property-bag">declaration property bag</a> to
<var>PROPERTIES</var></li>
I feel like the renaming should happen earlier, on line 687:
Let TYPE be the value of ELEMENT's name attribute, converted to lowercase.
etc.
https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html File spec/custom/index.html (right): https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html#newcode696 spec/custom/index.html:696: <li>Let <var>DECLARATION</var> be a <a href="#dfn-custom-element-declaration">custom element declaration</a> with ...
11 years, 7 months ago
(2013-06-18 17:04:58 UTC)
#2
https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html
File spec/custom/index.html (right):
https://codereview.appspot.com/10340045/diff/1/spec/custom/index.html#newcode696
spec/custom/index.html:696: <li>Let <var>DECLARATION</var> be a <a
href="#dfn-custom-element-declaration">custom element declaration</a> with <a
href="#dfn-custom-element-type">custom element type</a> set to <var>NAME</var>,
<a href="#dfn-base-element-name">base element name</a> to <var>BASE</var>, <a
href="#dfn-constructor-name">constructor name</a> to <var>CONSTRUCTOR</var>, and
<a href="#dfn-declaration-property-bag">declaration property bag</a> to
<var>PROPERTIES</var></li>
On 2013/06/18 00:30:31, dominicc-chromium wrote:
> I feel like the renaming should happen earlier, on line 687:
>
> Let TYPE be the value of ELEMENT's name attribute, converted to lowercase.
>
> etc.
Great idea! Thanks!
Issue 10340045: [Custom]: Change to use custom element type, rather than custom element name.
(Closed)
Created 11 years, 7 months ago by Dimitri Glazkov
Modified 11 years, 7 months ago
Reviewers: dominicc-chromium
Base URL:
Comments: 3