Issue 10337043: V8 API: Add a missing NULL check into Isolate::GetCurrentContext().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10337043: V8 API: Add a missing NULL check into Isolate::GetCurrentContext().

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by aandrey

Modified:
11 years, 10 months ago

Reviewers:
Yury Semikhatsky, dcarney, mvstanton, mstarzinger

CC:
v8-dev_chromium.org

Base URL:
https://chromium.googlesource.com/external/v8.git@master

Visibility:
Public.

More Reviews

Description

V8 API: Add a missing NULL check into Isolate::GetCurrentContext(). There is a missing NULL check for: "internal_isolate->context() != NULL". Right now before calling this method one should call v8::Context::InContext() first to perform this check, otherwise we may crash. But this static method will do this check on the current isolate, which may not be the same as a given one. BUG=249655 R=yurys@chromium.org,mvstanton@chromium.org