Issue 10330044: Separates jinja2 templates from JS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10330044: Separates jinja2 templates from JS

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by sharky93

Modified:
11 years, 5 months ago

Reviewers:
TheSheep

Visibility:
Public.

More Reviews

Patch Set 2 : JS statically served, one global function #

Total comments: 3

Patch Set 3 : Test before commit #

Patch Set 4 : Test #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -15 lines)			Patch
M	MoinMoin/static/js/common.js	View	1 2 3	4 chunks	+8 lines, -8 lines	0 comments	Download
M	MoinMoin/static/js/index_action.js	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
A	MoinMoin/static/js/jquery.i18n.min.js	View	1 2 3	1 chunk	+13 lines, -0 lines	0 comments	Download
M	MoinMoin/templates/base.html	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
A	MoinMoin/templates/dictionary.js	View	1 3	1 chunk	+24 lines, -0 lines	0 comments	Download
M	MoinMoin/templates/index.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

TheSheep

https://codereview.appspot.com/10330044/diff/1/MoinMoin/templates/base.html File MoinMoin/templates/base.html (right): https://codereview.appspot.com/10330044/diff/1/MoinMoin/templates/base.html#newcode74 MoinMoin/templates/base.html:74: <script src="{{ url_for('frontend.template', filename='jquery.i18n.min.js') }}"></script> This should be a ...

11 years, 5 months ago (2013-06-18 08:11:48 UTC) #1

TheSheep

11 years, 5 months ago (2013-06-18 13:26:25 UTC) #2

https://codereview.appspot.com/10330044/diff/14001/MoinMoin/templates/diction...
File MoinMoin/templates/dictionary.js (right):

https://codereview.appspot.com/10330044/diff/14001/MoinMoin/templates/diction...
MoinMoin/templates/dictionary.js:3: }
var _ = $.i18n._;

https://codereview.appspot.com/10330044/diff/14001/MoinMoin/templates/index_a...
File MoinMoin/templates/index_action.js (right):

https://codereview.appspot.com/10330044/diff/14001/MoinMoin/templates/index_a...
MoinMoin/templates/index_action.js:19: ACTION_LOADING = {'delete':
_("Deleting"), 'destroy': _("Destroying")},
"Deleting..", "Destroying.."

https://codereview.appspot.com/10330044/diff/14001/MoinMoin/templates/index_a...
MoinMoin/templates/index_action.js:21: ACTION_FAILED = {'delete': _(", Items not
deleted: "), 'destroy': _(", Items not destroyed: ")}
Missing ;

Expand All Messages | Collapse All Messages