Issue 103260043: Cleanup observer cleanup code. Also, add testing that asserts that observers are properly closed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 103260043: Cleanup observer cleanup code. Also, add testing that asserts that observers are properly closed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rafaelw

Modified:
11 years, 8 months ago

Reviewers:
sorvell, sjmiles

Base URL:
git@github.com:Polymer/polymer-dev.git@master

Visibility:
Public.

More Reviews

Description

Cleanup observer cleanup code. Also, add testing that asserts that observers are properly closed. R=sorvell@google.com, sorvell BUG= Committed: https://github.com/Polymer/polymer-dev/commit/a624fa2

Patch Set 1 #

Patch Set 2 : ouch #

Patch Set 3 : foo #

Patch Set 4 : foo #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -31 lines)			Patch
M	src/instance/mdv.js	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/instance/properties.js	View		3 chunks	+18 lines, -16 lines	0 comments	Download
M	test/html/unbind.html	View	3	4 chunks	+30 lines, -14 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rafaelw

Note that we weren't leaking observers. The test just needed to properly close all custom ...

11 years, 8 months ago (2014-06-10 00:43:06 UTC) #1

rafaelw

11 years, 8 months ago (2014-06-10 03:32:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as ra624fa2 (presubmit successful).

Expand All Messages | Collapse All Messages