HttpResponseBuilder-extends-MutableContent

@see thread on dev@shindig.apache.org for discussion regarding the motivation for this CL (posting now)

[jtarrio, 2010-05-03 21:55:50]

lgtm

[johnfargo, 2010-05-03 23:12:01]

Thanks Jacobo. Any objections from others? If not I'll be submitting in a
reasonably short time frame...

On Mon, May 3, 2010 at 2:55 PM, <jtarrio@gmail.com> wrote:

> lgtm
>
>
> http://codereview.appspot.com/1032042/show
>

[Paul Lindner, 2010-05-03 23:36:37]

lgtm

[henry.saputra, 2010-05-03 23:39:32]

http://codereview.appspot.com/1032042/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java
(right):

http://codereview.appspot.com/1032042/diff/1/2#newcode144
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:144:
contentBytes = content.getBytes("UTF8");
Just curious is the charset name should be "UTF-8" or use CharsetUtil.UTF8?

[johnfargo, 2010-05-03 23:43:25]

I suppose it couldn't hurt to just use CharsetUtil.getUtf8Bytes() - obviates
the need for a try/catch block as well. Seem reasonable?

On Mon, May 3, 2010 at 4:39 PM, <henry.saputra@gmail.com> wrote:

>
> http://codereview.appspot.com/1032042/diff/1/2
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java
> (right):
>
> http://codereview.appspot.com/1032042/diff/1/2#newcode144
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:144:
> contentBytes = content.getBytes("UTF8");
> Just curious is the charset name should be "UTF-8" or use
> CharsetUtil.UTF8?
>
>
> http://codereview.appspot.com/1032042/show
>

[johnfargo, 2010-05-04 00:23:37]

Went ahead and used CharsetUtil.getUtf8Bytes(...), and committed.

On Mon, May 3, 2010 at 4:43 PM, John Hjelmstad <johnfargo@gmail.com> wrote:

> I suppose it couldn't hurt to just use CharsetUtil.getUtf8Bytes() -
> obviates the need for a try/catch block as well. Seem reasonable?
>
> On Mon, May 3, 2010 at 4:39 PM, <henry.saputra@gmail.com> wrote:
>
>>
>> http://codereview.appspot.com/1032042/diff/1/2
>> File
>>
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java
>> (right):
>>
>> http://codereview.appspot.com/1032042/diff/1/2#newcode144
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:144:
>> contentBytes = content.getBytes("UTF8");
>> Just curious is the charset name should be "UTF-8" or use
>> CharsetUtil.UTF8?
>>
>>
>> http://codereview.appspot.com/1032042/show
>>
>
>

[henry.saputra, 2010-05-04 00:49:26]

+1 using CharsetUtils.getUtf8Bytes instead

- Henry

On Mon, May 3, 2010 at 4:43 PM, John Hjelmstad <johnfargo@gmail.com> wrote:

> I suppose it couldn't hurt to just use CharsetUtil.getUtf8Bytes() -
> obviates the need for a try/catch block as well. Seem reasonable?
>
> On Mon, May 3, 2010 at 4:39 PM, <henry.saputra@gmail.com> wrote:
>
>>
>> http://codereview.appspot.com/1032042/diff/1/2
>> File
>>
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java
>> (right):
>>
>> http://codereview.appspot.com/1032042/diff/1/2#newcode144
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:144:
>> contentBytes = content.getBytes("UTF8");
>> Just curious is the charset name should be "UTF-8" or use
>> CharsetUtil.UTF8?
>>
>>
>> http://codereview.appspot.com/1032042/show
>>
>
>