Issue 103100043: Fix GObject leaks in ibus_property_deserialize()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 103100043: Fix GObject leaks in ibus_property_deserialize() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by fujiwara

Modified:
10 years ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara, cfergeau_redhat.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix GObject leaks in ibus_property_deserialize() BUG=http://code.google.com/p/ibus/issues/detail?id=1712

Patch Set 1 #

Patch Set 2 : Updated with the latest master. #

Patch Set 3 : Fix leak of deserialize(IBusProperty.icon). #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	src/ibusproperty.c	View	1 2	2 chunks	+13 lines, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

10 years ago (2014-06-06 07:39:27 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/103100043/diff/40001/src/ibusproperty.c
File src/ibusproperty.c (right):

https://codereview.appspot.com/103100043/diff/40001/src/ibusproperty.c#newcod...
src/ibusproperty.c:413: ibus_g_variant_get_child_string (variant, retval++,
&prop->priv->icon);
Fixed the left leak.

Expand All Messages | Collapse All Messages