Make third argument to PathObserver callback path

Make third argument to PathObserver callback path

R=arv
BUG=https://github.com/Polymer/observe-js/issues/52

Committed: https://github.com/Polymer/observe-js/commit/4905f0b

[rafaelw, 2014-05-29 20:45:51]

Committed patchset #1 manually as r4905f0b (presubmit successful).

[John Messerly, 2014-05-29 21:08:37]

https://codereview.appspot.com/102890044/diff/1/src/observe.js
File src/observe.js (right):

https://codereview.appspot.com/102890044/diff/1/src/observe.js#newcode1033
src/observe.js:1033: this.report_([this.value_, oldValue, this.path_]);
I wonder if path should be a public field/getter in addition (or instead)? 
Might be easier than passing "path_" to the callback, since presumably the code
already has the PathObserver instance. (or maybe pass "this" as 3rd arg)

IIRC Polymer uses it somewhere too (in the "bind" code path), and they read
"path_".

[rafaelw, 2014-05-29 22:12:21]

https://codereview.appspot.com/102890044/diff/1/src/observe.js
File src/observe.js (right):

https://codereview.appspot.com/102890044/diff/1/src/observe.js#newcode1033
src/observe.js:1033: this.report_([this.value_, oldValue, this.path_]);
I like that. So how about making path a "public" property (e.g. path_ -> path)
and passing |this| as the third argument?

On 2014/05/29 21:08:36, John Messerly wrote:
> I wonder if path should be a public field/getter in addition (or instead)? 
> Might be easier than passing "path_" to the callback, since presumably the
code
> already has the PathObserver instance. (or maybe pass "this" as 3rd arg)
> 
> IIRC Polymer uses it somewhere too (in the "bind" code path), and they read
> "path_".

[rafaelw, 2014-05-29 22:13:37]

https://codereview.appspot.com/99660045/

[John Messerly, 2014-05-29 22:33:46]

https://codereview.appspot.com/102890044/diff/1/src/observe.js
File src/observe.js (right):

https://codereview.appspot.com/102890044/diff/1/src/observe.js#newcode1033
src/observe.js:1033: this.report_([this.value_, oldValue, this.path_]);
SGTM :)

On 2014/05/29 22:12:21, rafaelw wrote:
> I like that. So how about making path a "public" property (e.g. path_ -> path)
> and passing |this| as the third argument?
> 
> On 2014/05/29 21:08:36, John Messerly wrote:
> > I wonder if path should be a public field/getter in addition (or instead)? 
> > Might be easier than passing "path_" to the callback, since presumably the
> code
> > already has the PathObserver instance. (or maybe pass "this" as 3rd arg)
> > 
> > IIRC Polymer uses it somewhere too (in the "bind" code path), and they read
> > "path_".
>