Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 10269: Adding local file rendering support to Sample Container

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 3 months ago by levik
Modified:
16 years, 2 months ago
Reviewers:
Henning, shindig-dev, louiscryan, etnu00
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

This patch enables Shindig's Sample Container to render files local to the developer's machine. This is facilitated by adding a Servlet that serves these files (only to localhost requests). The Sample Container UI has been changed to support this feature (including allowing one to pick a file from the local filesystem via a file input control) JIRA Issue: https://issues.apache.org/jira/browse/SHINDIG-775

Patch Set 1 #

Patch Set 2 : Updated LocalServlet to use IOUtils, commented it out in web.xml files #

Patch Set 3 : Moved LocalFileServlet to server/src/main/java/.../sample #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -41 lines) Patch
java/gadgets/pom.xml View 2 1 chunk +4 lines, -0 lines 0 comments Download
java/server/src/main/java/org/apache/shindig/server/sample/LocalFileServlet.java View 1 chunk +74 lines, -0 lines 0 comments Download
java/server/src/main/webapp/WEB-INF/web.xml View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
java/server/src/main/webapp/WEB-INF/web.full.xml View 1 2 2 chunks +14 lines, -1 line 0 comments Download
java/server/src/main/webapp/WEB-INF/web.gadgets.xml View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
javascript/samplecontainer/samplecontainer.html View 1 2 2 chunks +78 lines, -38 lines 0 comments Download
javascript/samplecontainer/samplecontainer.js View 1 2 6 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 6
levik
16 years, 3 months ago (2008-12-10 23:05:10 UTC) #1
etnu00
Why not just configure jetty to serve static files?
16 years, 3 months ago (2008-12-10 23:38:00 UTC) #2
louiscryan
Overall looks fine, couple of minor comments. http://codereview.appspot.com/10269/diff/1/5 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/localfile/LocalFileServlet.java (right): http://codereview.appspot.com/10269/diff/1/5#newcode37 Line 37: * ...
16 years, 3 months ago (2008-12-12 02:09:35 UTC) #3
levik
Updated LocalServlet to use IOUtils, commented it out in web.xml files
16 years, 3 months ago (2008-12-15 18:11:17 UTC) #4
Henning
First and most important question for me would be: What do you need this for? ...
16 years, 3 months ago (2008-12-17 17:31:52 UTC) #5
levik
16 years, 2 months ago (2009-01-12 21:17:40 UTC) #6
Moved LocalFileServlet to server/src/main/java/.../sample
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b