Issue 10247045: Suppress warnings for deprecated GdkColor usage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10247045: Suppress warnings for deprecated GdkColor usage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Daiki Ueno

Modified:
12 years, 7 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

More Reviews

Description

Suppress warnings for deprecated GdkColor usage BUG= Committed: 43b3812

Patch Set 2 : just suppress warnings, not drop gtk2 #

Total comments: 3

Patch Set 3 : minor rename of helper functions and local variables (color -> rgba) #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -28 lines)			Patch
	M	src/setup.c	View	1 2	6 chunks	+93 lines, -28 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Daiki Ueno

On 2013/06/14 05:12:00, Daiki Ueno wrote: Maybe we should be conservative here. Uploaded a new ...

12 years, 7 months ago (2013-06-20 10:35:10 UTC) #2

Peng

https://codereview.appspot.com/10247045/diff/6001/src/setup.c File src/setup.c (right): https://codereview.appspot.com/10247045/diff/6001/src/setup.c#newcode244 src/setup.c:244: (gint) (color->red * 255), Why not << 8 or ...

12 years, 7 months ago (2013-06-20 13:44:00 UTC) #3

Daiki Ueno

12 years, 7 months ago (2013-06-20 13:57:58 UTC) #4

Peng

lgtm https://codereview.appspot.com/10247045/diff/6001/src/setup.c File src/setup.c (right): https://codereview.appspot.com/10247045/diff/6001/src/setup.c#newcode244 src/setup.c:244: (gint) (color->red * 255), On 2013/06/20 13:57:58, Daiki ...

12 years, 7 months ago (2013-06-20 14:26:49 UTC) #5

Daiki Ueno

12 years, 7 months ago (2013-06-21 02:04:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r43b3812 (presubmit successful).

Expand All Messages | Collapse All Messages