Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(145)

Issue 10236047: Replace domitaModules with lexical variables. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by kpreid2
Modified:
12 years, 9 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

domitaModules was introduced at a time when attachDocument was a top-level function, and now has no advantage over lexical variables, nor is it currently used in any consistent fashion. @r5449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -38 lines) Patch
M src/com/google/caja/plugin/domado.js View 19 chunks +25 lines, -38 lines 0 comments Download

Messages

Total messages: 2
kpreid2
12 years, 9 months ago (2013-06-13 21:37:27 UTC) #1
felix8a
12 years, 9 months ago (2013-06-13 22:37:23 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b