Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178)

Issue 10236043: parse more css attribute match operators (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by felix8a
Modified:
12 years, 9 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Right now the cajoler fails to parse stuff like p[x$=y] {} and the parse failure causes it to throw out a lot more css than it should. Fixing the error recovery is somewhat nontrivial. Adding the new operators is trivial. Note, this just allows the operators to parse, but rejects them as not allowed, similar to the |= operator. So, the operators still don't work, but we recover from that better.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
M src/com/google/caja/lexer/CssLexer.java View 1 chunk +8 lines, -8 lines 0 comments Download
M src/com/google/caja/parser/css/CssParser.java View 1 chunk +12 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/css/CssTree.java View 1 chunk +3 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/CssValidator.java View 3 chunks +10 lines, -4 lines 0 comments Download
M src/com/google/caja/plugin/PluginMessageType.java View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/parser/css/cssparsergolden2.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M tests/com/google/caja/parser/css/cssparserinput2.css View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/com/google/caja/parser/css/cssrendergolden2.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/CssValidatorTest.java View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
felix8a
12 years, 9 months ago (2013-06-12 18:50:44 UTC) #1
ihab.awad
Changes so far LGTM, but should not submit without adding support for the same thing ...
12 years, 9 months ago (2013-06-12 19:10:10 UTC) #2
felix8a
On 2013/06/12 19:10:10, ihab.awad wrote: > Changes so far LGTM, but should not submit without ...
12 years, 9 months ago (2013-06-12 19:13:32 UTC) #3
felix8a
12 years, 9 months ago (2013-06-12 19:17:33 UTC) #4
@r5445
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b