Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 10234049: Micro cleanup/optimization. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by kpreid2
Modified:
12 years, 9 months ago
Reviewers:
felix8a, MarkM
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Added a cache mapping element names to taming classes, which bypasses going through both the HTML schema and taming class table when taming a node. Barely improves performance according to the Chrome profiler. * In defineElement ctors, don't call isVirtualizedElementName unless the result will be used. * Put simpler conditions first in repair_DEFINE_PROPERTY. * Remove setOwn and definePropertyAllowOverride in Domado in favor of more explicit and specialized forms which do not need to do reflection to decide what to do. * Added missing documentation for virtualized parameter to defineElement. @r5448

Patch Set 1 #

Total comments: 2

Patch Set 2 : Micro cleanup/optimization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -66 lines) Patch
M src/com/google/caja/plugin/domado.js View 1 17 chunks +56 lines, -62 lines 0 comments Download
M src/com/google/caja/ses/repairES5.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5
kpreid2
12 years, 9 months ago (2013-06-13 18:31:57 UTC) #1
MarkM
ses/* stuff LGTM
12 years, 9 months ago (2013-06-13 18:44:50 UTC) #2
felix8a
lgtm https://codereview.appspot.com/10234049/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/10234049/diff/1/src/com/google/caja/plugin/domado.js#newcode3094 src/com/google/caja/plugin/domado.js:3094: setToString(TameNamedNodeMap.prototype, cajaVM.def(function() { any reason this is def ...
12 years, 9 months ago (2013-06-13 18:55:16 UTC) #3
kpreid2
* Added a cache mapping element names to taming classes, which bypasses going through both ...
12 years, 9 months ago (2013-06-13 18:59:12 UTC) #4
kpreid2
12 years, 9 months ago (2013-06-13 19:00:00 UTC) #5
https://codereview.appspot.com/10234049/diff/1/src/com/google/caja/plugin/dom...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/10234049/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:3094:
setToString(TameNamedNodeMap.prototype, cajaVM.def(function() {
On 2013/06/13 18:55:17, felix8a wrote:
> any reason this is def instead of constfunc (or innocuous)? a few more below
> too.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b