Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 10222043: clarify browser test names in test-index (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by felix8a
Modified:
12 years, 9 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Browser tests names are now something like 'cajajs-invocation-min-es53', which is the name you'd use to run one test with -Dtest.filter.method, but these names are not anywhere literally in the source any more, and it's not obvious how to construct a valid name. The test names are visible in the ant test report summary, but test-index.html annoyingly does not show these test names. It's possible to construct a valid test name from the info on test-index.html, but the method for doing that is not obvious. This change makes it obvious. test-index.html used to look like: cajajs invocation es53 es5 nomin es53 es5 min es53[min nomin] es5[min nomin] version-skew-js-files It now looks like: cajajs- invocation- nomin- {es53 es5} min- {es53 es5} version-skew-js-files- {es53- {min nomin} es5- {min nomin}}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M tests/com/google/caja/plugin/test-index.html View 2 chunks +11 lines, -2 lines 2 comments Download
M tests/com/google/caja/plugin/test-index.js View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 9 months ago (2013-06-12 04:23:07 UTC) #1
kpreid2
LGTM https://codereview.appspot.com/10222043/diff/1/tests/com/google/caja/plugin/test-index.html File tests/com/google/caja/plugin/test-index.html (right): https://codereview.appspot.com/10222043/diff/1/tests/com/google/caja/plugin/test-index.html#newcode28 tests/com/google/caja/plugin/test-index.html:28: padding-left: 2em; Add .comment to the selector on ...
12 years, 9 months ago (2013-06-12 16:51:54 UTC) #2
felix8a
12 years, 9 months ago (2013-06-12 19:11:50 UTC) #3
@r5444

https://codereview.appspot.com/10222043/diff/1/tests/com/google/caja/plugin/t...
File tests/com/google/caja/plugin/test-index.html (right):

https://codereview.appspot.com/10222043/diff/1/tests/com/google/caja/plugin/t...
tests/com/google/caja/plugin/test-index.html:28: padding-left: 2em;
On 2013/06/12 16:51:54, kpreid2 wrote:
> Add .comment to the selector on line 42 below instead of duplicating this
value.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b