Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(440)

Issue 1019041: Shindig Feed Processor: Parse MediaRSS items into optional Media element (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by mat.mannion
Modified:
15 years, 8 months ago
Reviewers:
Paul Lindner, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

It can be useful when displaying the results of FEED type makeRequests to be able to see if any <media:content /> or <media:thumbnail /> elements were included. This patch adds support for this while maintaining all existing behaviour.

Patch Set 1 : Apologies, uploaded wrong patch set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -79 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/FeedProcessor.java View 1 chunk +145 lines, -79 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/FeedProcessorTest.java View 4 chunks +156 lines, -0 lines 0 comments Download
pom.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7
mat.mannion
15 years, 9 months ago (2010-04-27 13:17:18 UTC) #1
mat.mannion
Apologies, uploaded wrong patch set
15 years, 9 months ago (2010-04-27 13:19:15 UTC) #2
Paul Lindner
Looks good to me. I can fix up the tabs vs spaces. Anyone opposed to ...
15 years, 8 months ago (2010-04-28 17:54:14 UTC) #3
mat.mannion
On 28 April 2010 18:54, Paul Lindner <lindner@inuus.com> wrote: > I can fix up the ...
15 years, 8 months ago (2010-04-28 20:01:16 UTC) #4
Paul Lindner
+dev@shindig.apache.org Getting one more round of feedback, if no objections I'll commit this tomorrow via ...
15 years, 8 months ago (2010-05-04 20:08:16 UTC) #5
Paul Lindner
patch applied. Could you also file a jira with the patch so we can get ...
15 years, 8 months ago (2010-05-06 14:26:41 UTC) #6
mat.mannion
15 years, 8 months ago (2010-05-06 14:30:07 UTC) #7
On 2010/05/06 14:26:41, Paul Lindner wrote:
> patch applied.  Could you also file a jira with the patch so we can get proper
> IP clearance?
> 
> Thanks!

No probs; done (SHINDIG-1323)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b