Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(212)

Issue 101880043: code review 101880043: lib/time: update time zone files to version 2014d (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by oneofone
Modified:
11 years, 3 months ago
Reviewers:
r, ruiu, bradfitz, gobot
CC:
golang-codereviews
Visibility:
Public.

Description

lib/time: update time zone files to version 2014d Trying codereview with something simple.

Patch Set 1 #

Patch Set 2 : diff -r 900650e66b4f https://code.google.com/p/go #

Patch Set 3 : diff -r f39e79378a3b https://code.google.com/p/go #

Patch Set 4 : diff -r 5bf1a8b3aeea https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/time/update.bash View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11
oneofone
Hello golang-dev@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2014-05-28 22:44:59 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
11 years, 3 months ago (2014-05-28 22:47:59 UTC) #2
oneofone
On 2014/05/28 22:47:59, gobot wrote: > Replacing golang-dev with golang-codereviews. > > To the author ...
11 years, 3 months ago (2014-05-28 23:00:11 UTC) #3
bradfitz
R=r
11 years, 3 months ago (2014-05-30 04:40:11 UTC) #4
ruiu
I'd think I may be a bit paranoia, but I want someone in the Go ...
11 years, 3 months ago (2014-05-30 07:46:01 UTC) #5
bradfitz
I was thinking the same, actually. On May 30, 2014 4:46 PM, "'Rui Ueyama' via ...
11 years, 3 months ago (2014-05-30 07:48:41 UTC) #6
oneofone
Is there a way for me to modify the patchset to remove the zip? On ...
11 years, 3 months ago (2014-05-30 09:29:10 UTC) #7
oneofone
Figured it out, sorry for the spam. On 2014/05/30 09:29:10, oneofone wrote: > Is there ...
11 years, 3 months ago (2014-05-30 09:34:35 UTC) #8
r
Please abandon this and I will do the update. Note to self: don't bother with ...
11 years, 3 months ago (2014-06-01 00:07:33 UTC) #9
gobot
R=close (assigned by r@golang.org)
11 years, 3 months ago (2014-06-01 00:07:45 UTC) #10
oneofone
11 years, 3 months ago (2014-06-02 05:05:23 UTC) #11
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b