Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 101820044: cmd/juju: Fixes #1323263: drop --exclude-networks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dimitern
Modified:
11 years, 9 months ago
Reviewers:
mp+221255, mfoord
Visibility:
Public.

Description

cmd/juju: Fixes #1323263: drop --exclude-networks Removed --exclude-networks argument from juju deploy CLI. Also fixed the command help text. In a follow-up, after we introduce network constraints, the ability to specify what networks to exclude will be restored. For now, we just need to drop the CLI argument, as it was decided we don't need it, and needs to be done before the next release. https://code.launchpad.net/~dimitern/juju-core/450-lp-1323263-remove-exclude-networks/+merge/221255 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -33 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/deploy.go View 6 chunks +19 lines, -31 lines 0 comments Download
M cmd/juju/deploy_test.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
dimitern
Please take a look.
11 years, 9 months ago (2014-05-28 15:15:30 UTC) #1
mfoord
11 years, 9 months ago (2014-05-28 15:25:29 UTC) #2
On 2014/05/28 15:15:30, dimitern wrote:
> Please take a look.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b