Issue 101710049: Adds a new flag to disable Breakpad error reporting in SyzyASan.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 101710049: Adds a new flag to disable Breakpad error reporting in SyzyASan. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by Sébastien Marchand

Modified:
9 years, 10 months ago

Reviewers:
chrisha, Siggi

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Adds a new flag to disable Breakpad error reporting in SyzyASan. TBR=chrisha@chromium.org, siggi@chromium.org BUG= Committed: https://code.google.com/p/sawbuck/source/detail?r=2179

Patch Set 1 : #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
M	syzygy/agent/asan/asan_runtime.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	syzygy/agent/asan/asan_runtime_unittest.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	syzygy/common/asan_parameters.h	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	syzygy/common/asan_parameters.cc	View	4 chunks	+6 lines, -0 lines	0 comments	Download
M	syzygy/common/asan_parameters_unittest.cc	View	4 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sébastien Marchand

Committing as TBR as this break Clusterfuzz.

9 years, 10 months ago (2014-07-07 22:19:41 UTC) #2

Sébastien Marchand

Committed patchset #1 manually as r2179 (presubmit successful).

9 years, 10 months ago (2014-07-07 22:46:16 UTC) #3

Message was sent while issue was closed.

lgtm

Expand All Messages | Collapse All Messages