Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(155)

Issue 101640044: Change names to Application Default Credentials and change doc and error message to staged versions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by Anthony Moore
Modified:
11 years, 4 months ago
Reviewers:
wonderfly
CC:
Orest, craigcitro-work
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

Change names to Application Default Credentials and change doc and error message to staged versions.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebase and change doc comment casing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java View 1 3 chunks +11 lines, -13 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java View 1 2 chunks +14 lines, -14 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredentialTest.java View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Anthony Moore
11 years, 5 months ago (2014-07-02 18:24:51 UTC) #1
wonderfly
LGTM with a few nits. https://codereview.appspot.com/101640044/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java File google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java (right): https://codereview.appspot.com/101640044/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java#newcode70 google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java:70: * authorize the whole ...
11 years, 5 months ago (2014-07-02 21:50:13 UTC) #2
Anthony Moore
Replied to open comments. https://codereview.appspot.com/101640044/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java File google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java (right): https://codereview.appspot.com/101640044/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java#newcode70 google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java:70: * authorize the whole application. ...
11 years, 5 months ago (2014-07-02 22:14:00 UTC) #3
Anthony Moore
11 years, 5 months ago (2014-07-02 23:08:49 UTC) #4
Rebased and change some doc comment casing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b