Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 10156044: Modify valac --target-glib. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by fujiwara
Modified:
11 years, 5 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Modify valac --target-glib. valac --ccode --target-glib=2.36 can disable g_type_init in the generated C files since g_type_init is deprecated in glib 2.36. But ibus tarball includes C files so that users do not require vala and vala versions are different between dist and build. If dist could have glib 2.36 to generate the ibus tarball but a user build would have glib 2.34, the user build would be failed because glib 2.34 requires g_type_init. This change makes sure the target-glib is minimum of the glib version for ibus.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #4. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M configure.ac View 1 2 chunks +5 lines, -3 lines 0 comments Download
M engine/Makefile.am View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/Makefile.am View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gtk3/Makefile.am View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
fujiwara
11 years, 5 months ago (2013-06-11 00:47:29 UTC) #1
Peng
On 2013/06/11 00:47:29, fujiwara wrote: I think the comments is not very clear. Could you ...
11 years, 5 months ago (2013-06-11 01:27:07 UTC) #2
fujiwara
On 2013/06/11 01:27:07, Peng wrote: > On 2013/06/11 00:47:29, fujiwara wrote: > > I think ...
11 years, 5 months ago (2013-06-11 01:45:41 UTC) #3
Peng
https://codereview.appspot.com/10156044/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/10156044/diff/1/configure.ac#newcode55 configure.ac:55: GLIB_REQUIRED_VERSION=glib_required_version Gould we rename it to vala_target_glib_version and assign ...
11 years, 5 months ago (2013-06-11 02:58:04 UTC) #4
fujiwara
https://codereview.appspot.com/10156044/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/10156044/diff/1/configure.ac#newcode55 configure.ac:55: GLIB_REQUIRED_VERSION=glib_required_version On 2013/06/11 02:58:04, Peng wrote: > Gould we ...
11 years, 5 months ago (2013-06-11 03:35:36 UTC) #5
Peng
11 years, 5 months ago (2013-06-11 03:39:30 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b