Run xmodmap after run setxkbmap -l layout.

Run xmodmap after run setxkbmap -l layout.


BUG=rhbz#750484
TEST=ui/gtk3/ibus-ui-gtk3 data/dconf/org.freedesktop.ibus.gschema.xml

[fujiwara, 2014-06-24 10:21:04]

If both setxkbmap and xmodmap is sync, it seems dbus timeout happens and xmodmap
causes a infinite loop.
If setxkbmap is async, setting keymap is sometimes lost in case the global
engine mode is disabled.
If xmodmap is async, setting xmodmap is sometimes lost in case the global engine
mode is disabled.
At the moment, I call setxkbmap with sync and xmodmap with async.

[fujiwara, 2014-06-24 13:25:05]

On 2014/06/24 10:21:04, fujiwara wrote:
> If both setxkbmap and xmodmap is sync, it seems dbus timeout happens and
xmodmap
> causes a infinite loop.
> If setxkbmap is async, setting keymap is sometimes lost in case the global
> engine mode is disabled.
> If xmodmap is async, setting xmodmap is sometimes lost in case the global
engine
> mode is disabled.
> At the moment, I call setxkbmap with sync and xmodmap with async.

[Peng, 2014-06-24 20:10:35]

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala
File ui/gtk3/xkblayout.vala (right):

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:262: GLib.Process.spawn_async(null,
use sync version?

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:266: GLib.SpawnFlags.SEARCH_PATH,
If you use SEARCH_PATH, we you still need search the xmodmap in $PATH by
yourself?

[fujiwara, 2014-06-25 05:59:26]

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala
File ui/gtk3/xkblayout.vala (right):

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:262: GLib.Process.spawn_async(null,
On 2014/06/24 20:10:35, Peng wrote:
> use sync version?

At the moment, I call setxkbmap with sync and xmodmap with async.
If both setxkbmap and xmodmap is sync, it seems dbus timeout happens and xmodmap
causes a loop for a while and users would think panel icon is frozen.
If setxkbmap is async, setting keymap is sometimes lost in case the global
engine mode is disabled.
If xmodmap is async, setting xmodmap is sometimes lost in case the global engine
mode is disabled.

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:266: GLib.SpawnFlags.SEARCH_PATH,
On 2014/06/24 20:10:35, Peng wrote:
> If you use SEARCH_PATH, we you still need search the xmodmap in $PATH by
> yourself?

I expect setxkbmap is required but xmodmap is nice to have.
If xmodmap is not installed, the fork is a heavy process so if xmodmap is not
found in $PATH, return here before spawn is called.
SEARCH_PATH flag just follows the case of setxkbmap.

[Peng, 2014-06-25 15:43:58]

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala
File ui/gtk3/xkblayout.vala (right):

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:241: return;
Should we just return here? or just run the xmodmap again. Let the X system
handles it.

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:262: GLib.Process.spawn_async(null,
On 2014/06/25 05:59:26, fujiwara wrote:
> On 2014/06/24 20:10:35, Peng wrote:
> > use sync version?
> 
> At the moment, I call setxkbmap with sync and xmodmap with async.
> If both setxkbmap and xmodmap is sync, it seems dbus timeout happens and
xmodmap
> causes a loop for a while and users would think panel icon is frozen.
> If setxkbmap is async, setting keymap is sometimes lost in case the global
> engine mode is disabled.
> If xmodmap is async, setting xmodmap is sometimes lost in case the global
engine
> mode is disabled.

IC.

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:266: GLib.SpawnFlags.SEARCH_PATH,
On 2014/06/25 05:59:26, fujiwara wrote:
> On 2014/06/24 20:10:35, Peng wrote:
> > If you use SEARCH_PATH, we you still need search the xmodmap in $PATH by
> > yourself?
> 
> I expect setxkbmap is required but xmodmap is nice to have.
> If xmodmap is not installed, the fork is a heavy process so if xmodmap is not
> found in $PATH, return here before spawn is called.
> SEARCH_PATH flag just follows the case of setxkbmap.

I think fork is pretty cheap on Linux system, but exec is heavy.
And if the xmodmap does exist on the system, your code will do extra checking.
It hurts performance, and makes code much complex.

And FYI,
g_find_program_in_path() could be used for finding program in $PATH

http://www.gtk.org/api/2.6/glib/glib-Miscellaneous-Utility-Functions.html#g-f...

[fujiwara, 2014-06-26 04:50:22]

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala
File ui/gtk3/xkblayout.vala (right):

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:241: return;
On 2014/06/25 15:43:58, Peng wrote:
> Should we just return here? or just run the xmodmap again. Let the X system
> handles it.

Yeah, I was also thinking about it.
Removed this line.

https://codereview.appspot.com/101490043/diff/1/ui/gtk3/xkblayout.vala#newcod...
ui/gtk3/xkblayout.vala:266: GLib.SpawnFlags.SEARCH_PATH,
On 2014/06/25 15:43:58, Peng wrote:
> On 2014/06/25 05:59:26, fujiwara wrote:
> > On 2014/06/24 20:10:35, Peng wrote:
> > > If you use SEARCH_PATH, we you still need search the xmodmap in $PATH by
> > > yourself?
> > 
> > I expect setxkbmap is required but xmodmap is nice to have.
> > If xmodmap is not installed, the fork is a heavy process so if xmodmap is
not
> > found in $PATH, return here before spawn is called.
> > SEARCH_PATH flag just follows the case of setxkbmap.
> 
> I think fork is pretty cheap on Linux system, but exec is heavy.
> And if the xmodmap does exist on the system, your code will do extra checking.
> It hurts performance, and makes code much complex.
> 
> And FYI,
> g_find_program_in_path() could be used for finding program in $PATH
> 
>
http://www.gtk.org/api/2.6/glib/glib-Miscellaneous-Utility-Functions.html#g-f...

OK, I agreed to remove the path check.

[Peng, 2014-07-03 14:29:13]

lgtm with a comment.

https://codereview.appspot.com/101490043/diff/20001/ui/gtk3/xkblayout.vala
File ui/gtk3/xkblayout.vala (right):

https://codereview.appspot.com/101490043/diff/20001/ui/gtk3/xkblayout.vala#ne...
ui/gtk3/xkblayout.vala:245: GLib.SpawnFlags.DO_NOT_REAP_CHILD |
Remove DO_NOT_REAP_CHILD? And let glib close the pid for you?

[fujiwara, 2014-07-04 06:59:51]

https://codereview.appspot.com/101490043/diff/20001/ui/gtk3/xkblayout.vala
File ui/gtk3/xkblayout.vala (right):

https://codereview.appspot.com/101490043/diff/20001/ui/gtk3/xkblayout.vala#ne...
ui/gtk3/xkblayout.vala:245: GLib.SpawnFlags.DO_NOT_REAP_CHILD |
On 2014/07/03 14:29:13, Peng wrote:
> Remove DO_NOT_REAP_CHILD? And let glib close the pid for you?

I removed DO_NOT_REAP_CHILD and run_xmodmap_cb().