DescriptionMakes navigation hash and qs safe
This branch address two problems occuring in navigation
-onLogin is eating querystrings and hashes when a url with them is entered
into a location bar as part of the process of processing namespaces in the
url. To remedy this, we get the processed url, then add the querystring and
hash to it.
-_navigate in the routing extension wasn't hash aware. We copy the getQS
methods for hashes.
Looking at other commits in this area of the code, it looks like this is
regrettably untestable. (e.g. r667 touched this same part of onlogin and
pointed out we can't handle nav tests in test-prod). If the reviewer has
suggestions, I'm happy to pursue them.
https://code.launchpad.net/~jcsackett/juju-gui/why-do-the-querystrings-die-why-why/+merge/168153
(do not edit description out of merge proposal)
Patch Set 1 #Patch Set 2 : Makes navigation hash and qs safe #
MessagesTotal messages: 5
|