Issue 100970044: Replace sample perf trace with properly merged one

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 100970044: Replace sample perf trace with properly merged one (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by Sami Kyöstilä

Modified:
11 years, 1 month ago

Reviewers:
dsinclair, nduca

CC:
trace-viewer-review_googlegroups.com

Base URL:
http://trace-viewer.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Replace sample perf trace with properly merged one This replaces the previous perf sampling sample trace with one where trace and perf events have been properly merged into a single JSON structure. TBR=nduca@chromium.org,dsinclair@chromium.org Committed: https://code.google.com/p/trace-viewer/source/detail?r=1285

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	D	test_data/perf_sampling_trace_with_trace_events.zip	View		Binary file		0 comments	Download
	A	test_data/perf_sampling_trace_with_trace_events.json.gz	View		Binary file		0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sami Kyöstilä

Here's what should be an actually correctly merged trace with perf and chrome trace data ...

11 years, 1 month ago (2014-06-03 18:56:36 UTC) #1

Sami Kyöstilä

11 years, 1 month ago (2014-06-03 18:57:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r1285 (presubmit successful).

Expand All Messages | Collapse All Messages