code review 1009041: xml: fix innerxml handling of & escapes

src/pkg/xml/read_test.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package xml
 
 import (
         "reflect"
         "testing"
 )
 
 // Stripped down Atom feed data structures.
 
 func TestUnmarshalFeed(t *testing.T) {
         var f Feed
         if err := Unmarshal(StringReader(rssFeedString), &f); err != nil {
                 t.Fatalf("Unmarshal: %s", err)
         }
         if !reflect.DeepEqual(f, rssFeed) {
                 t.Fatalf("have %#v\nwant %#v", f, rssFeed)
         }
 }
 
 // hget http://codereview.appspot.com/rss/mine/rsc
 const rssFeedString = `
 <?xml version="1.0" encoding="utf-8"?>
-<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-us"><title>Code Review - My issues</title><link href="http://codereview.appspot.com/" rel="alternate"></link><li-nk href="http://codereview.appspot.com/rss/mine/rsc" rel="self"></li-nk><id>http://codereview.appspot.com/</id><updated>2009-10-04T01:35:58+00:00</updated><author><name>rietveld</name></author><entry><title>rietveld: an attempt at pubsubhubbub
+<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-us"><title>Code Review - My issues</title><link href="http://codereview.appspot.com/" rel="alternate"></link><li-nk href="http://codereview.appspot.com/rss/mine/rsc" rel="self"></li-nk><id>http://codereview.appspot.com/</id><updated>2009-10-04T01:35:58+00:00</updated><author><name>rietveld&lt;&gt;</name></author><entry><title>rietveld: an attempt at pubsubhubbub
 </title><link hre-f="http://codereview.appspot.com/126085" rel="alternate"></link><updated>2009-10-04T01:35:58+00:00</updated><author><name>email-address-removed</name></author><id>urn:md5:134d9179c41f806be79b3a5f7877d19a</id><summary type="html">
   An attempt at adding pubsubhubbub support to Rietveld.
 http://code.google.com/p/pubsubhubbub
 http://code.google.com/p/rietveld/issues/detail?id=155
 
 The server side of the protocol is trivial:
   1. add a &amp;lt;link rel=&amp;quot;hub&amp;quot; href=&amp;quot;hub-server&amp;quot;&amp;gt; tag to all
      feeds that will be pubsubhubbubbed.
   2. every time one of those feeds changes, tell the hub
      with a simple POST request.
@@ skipping 80 matching lines @@
 var rssFeed = Feed{
         XMLName: Name{"http://www.w3.org/2005/Atom", "feed"},
         Title:   "Code Review - My issues",
         Link: []Link{
                 Link{Rel: "alternate", Href: "http://codereview.appspot.com/"},
                 Link{Rel: "self", Href: "http://codereview.appspot.com/rss/mine/rsc"},
         },
         Id:      "http://codereview.appspot.com/",
         Updated: "2009-10-04T01:35:58+00:00",
         Author: Person{
-                Name:     "rietveld",
-                InnerXML: "<name>rietveld</name>",
+                Name:     "rietveld<>",
+                InnerXML: "<name>rietveld&lt;&gt;</name>",
         },
         Entry: []Entry{
                 Entry{
                         Title: "rietveld: an attempt at pubsubhubbub\n",
                         Link: []Link{
                                 Link{Rel: "alternate", Href: "http://codereview.appspot.com/126085"},
                         },
                         Updated: "2009-10-04T01:35:58+00:00",
                         Author: Person{
                                 Name:     "email-address-removed",
@@ skipping 83 matching lines @@
 }
 
 func TestFieldName(t *testing.T) {
         for _, tt := range FieldNameTests {
                 a := fieldName(tt.in)
                 if a != tt.out {
                         t.Fatalf("have %#v\nwant %#v\n\n", a, tt.out)
                 }
         }
 }