Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 10087044: Update jQuery to 1.9 and remove test cajoling. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by kpreid2
Modified:
12 years, 9 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove the precajoling for jQuery tests because they contain content which the cajoler rejects, and since ES5/3 mode and the cajoler are deprecated it is not worth the effort to either loosen the restrictions or continue to patch the test suite to accept it. Also, there are now no build dependencies on the jQuery test suite. The eventual goal is to be able to test with different versions of jQuery by merely supplying a different test catalog. Currently we still find we need to patch the test suite itself for strict-mode restrictions. (jQuery 1.9 is not the latest version any more but it is what I have as part of this overall change.) @r5443

Patch Set 1 #

Patch Set 2 : Update jQuery to 1.9 and remove test cajoling. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -640 lines) Patch
M build.xml View 3 chunks +2 lines, -111 lines 0 comments Download
M src/com/google/caja/plugin/domado.js View 1 chunk +1 line, -1 line 1 comment Download
D tests/com/google/caja/jquery/hostpage-template.html View 1 chunk +0 lines, -82 lines 0 comments Download
D tests/com/google/caja/jquery/index.html View 1 chunk +0 lines, -108 lines 0 comments Download
D tests/com/google/caja/jquery/index-template.html View 1 chunk +0 lines, -267 lines 0 comments Download
M tests/com/google/caja/plugin/third-party-tests.json View 5 chunks +65 lines, -71 lines 0 comments Download

Messages

Total messages: 6
kpreid2
12 years, 9 months ago (2013-06-06 17:27:11 UTC) #1
kpreid2
Remove the precajoling for jQuery tests because they contain content which the cajoler rejects, and ...
12 years, 9 months ago (2013-06-06 17:28:28 UTC) #2
kpreid2
This review does not include the actual changes to jQuery itself because uploading broke twice. ...
12 years, 9 months ago (2013-06-06 17:30:33 UTC) #3
felix8a
lgtm
12 years, 9 months ago (2013-06-06 20:24:27 UTC) #4
kpreid2
On 2013/06/06 20:24:27, felix8a wrote: > lgtm Unfortunately r5440 (mitigate typeof by hiding ReferenceError instead ...
12 years, 9 months ago (2013-06-06 22:46:04 UTC) #5
kpreid2
12 years, 9 months ago (2013-06-08 00:28:44 UTC) #6
On 2013/06/06 22:46:04, kpreid2 wrote:
> On 2013/06/06 20:24:27, felix8a wrote:
> > lgtm
> 
> Unfortunately r5440 (mitigate typeof by hiding ReferenceError instead of
> rewriting typeof) caused broad test failures (that is, reduction in pass
counts)
> in this change. Looks like this in each file:
> 
> Sizzle: global failure (2, 0, 2)
>     TypeError: originaljQuery.ajax is not a function

Ihab and I looked at this today: the cause turned out to be that the test suite
is loading two copies of jQuery, one of which should end up in the
'originaljQuery' variable. That one is minified, and the minifier replaced a
string escape "\uFEFF" with a literal U+FEFF, which our parser for mitigation
rejected. It is as yet unclear why r5440 made a difference; for now, I simply
replaced the character in the minified jQuery with the escaped form.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b