Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(141)

Issue 10081043: Issue 3401: Parser error with void function in music list (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by dak
Modified:
12 years, 7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3401: Parser error with void function in music list Problem code fixed: test = (symbol-list?)) { \test Symbol } This patch is sort of a so-so fix for the problem: for one thing, embedded_scm_closed should not have been able to end in a symbol list in the first place since parsing those requires lookahead for '.'. The grammar has now been changed to use embedded_scm, and just backs up in the case a scheme function/identifier returns a markup in lyrics mode (which can then be assembled with duration and post-events into a more complex music expression). If parsing the source for the markup required lookahead, the same error will be thrown. But that use case of Scheme functions in Lyrics mode for generating markups to be turned into lyric events is a lot more exotic than the one triggering this issue. The current fix at least results in predictable behavior outside of using Lyrics mode, and in particular for uses of define-void-function.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M lily/parser.yy View 2 chunks +7 lines, -7 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b