this gets rid of most of the TypeLiterals<> and makes the code a bit cleaner ...
15 years, 8 months ago
(2010-04-29 09:04:09 UTC)
#1
this gets rid of most of the TypeLiterals<> and makes the code a bit cleaner and
easier to deal with.
Some of the Set<> bindings could be replaced with guice-multibinding if we want
to add another guice dependency
http://codereview.appspot.com/1008044/diff/1/3 File java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java (right): http://codereview.appspot.com/1008044/diff/1/3#newcode42 java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java:42: protected Set<String> getAllowedTags() { as a matter of convention, ...
15 years, 8 months ago
(2010-04-29 20:59:07 UTC)
#2
http://codereview.appspot.com/1008044/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java
(right):
http://codereview.appspot.com/1008044/diff/1/3#newcode42
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java:42:
protected Set<String> getAllowedTags() {
as a matter of convention, I'd prefer provideFoo rather than getFoo. The latter
sounds more like an accessor to me.
Issue 1008044: Use guice 2.0 features to clean up guice modules
(Closed)
Created 15 years, 8 months ago by Paul Lindner
Modified 15 years, 8 months ago
Reviewers: shindig.remailer_gmail.com, johnfargo
Base URL:
Comments: 1