Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(422)

Issue 1008044: Use guice 2.0 features to clean up guice modules (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by Paul Lindner
Modified:
15 years, 8 months ago
Reviewers:
johnfargo, shindig.remailer
Visibility:
Public.

Description

Use guice 2.0 features to clean up guice modules

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3
Paul Lindner
this gets rid of most of the TypeLiterals<> and makes the code a bit cleaner ...
15 years, 8 months ago (2010-04-29 09:04:09 UTC) #1
johnfargo
http://codereview.appspot.com/1008044/diff/1/3 File java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java (right): http://codereview.appspot.com/1008044/diff/1/3#newcode42 java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java:42: protected Set<String> getAllowedTags() { as a matter of convention, ...
15 years, 8 months ago (2010-04-29 20:59:07 UTC) #2
Paul Lindner
15 years, 8 months ago (2010-04-29 21:12:27 UTC) #3
okay, will rename to providesXXX and checkin.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b