Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 1008043: ns-3: Energy Model (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by (Tony) He Wu
Modified:
10 years, 3 months ago
CC:
ns-3-reviews_googlegroups.com, snabar_u.washington.edu, nbaldo_cttc.es
Visibility:
Public.

Description

Network Security Lab (NSL), University of Washington, Seattle has begun work on an generic energy model for ns3. The goal is to simulate an energy source and keep track of energy consumptions of various devices in the node. Current version focuses on radio energy consumption. The energy model has 2 major components: 1. Energy Source: Energy source model (eg. battery) which provides energy to all devices. 2. Devices energy model: Energy consumption model for specific devices (eg. radio) on the node. Note that device energy model depends on an energy source. This patch is based on the latest ns-3-dev tree. To use the energy model, apply the latest patch to ns-3-dev. wiki link: http://www.nsnam.org/wiki/index.php/NS-3_energy_model

Patch Set 1 #

Total comments: 15

Patch Set 2 : Fixes and modifications on first code review. #

Total comments: 14

Patch Set 3 : Fixes and modifications on second review. #

Patch Set 4 : Bug fixes and unit test suite. #

Patch Set 5 : Add tracing support. #

Patch Set 6 : Update according to latest dev tree. #

Patch Set 7 : Bug fix. Improved basic energy model test suite. #

Patch Set 8 : Move energy model to src/contrib/energy #

Patch Set 9 : Add example. Patch YansWifiPhy to support energy model. #

Patch Set 10 : Patch YansWifiPhy to support energy model. #

Patch Set 11 : Stop periodic update in BasicRadioEnergyModel after energy is depleted. #

Patch Set 12 : Add current interface & containers. Change install method. #

Patch Set 13 : Add support for multiple EnergySource on single node. #

Patch Set 14 : Patch WifiPhy & YansWifiPhy to support energy model. Add energy model example. #

Patch Set 15 : Add Rakhmatov-Vrudhula non-linear battery model. #

Total comments: 6

Patch Set 16 : Remove modification to WifiPhy and YansWifiPhy. Add WifiRadioEnergyModelPhyListener. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2314 lines, -278 lines) Patch
A examples/energy/energy-model-example.cc View 9 10 11 14 15 1 chunk +262 lines, -0 lines 0 comments Download
A examples/energy/waf View 1 chunk +1 line, -0 lines 0 comments Download
A examples/energy/wscript View 1 chunk +5 lines, -0 lines 0 comments Download
M src/contrib/energy/helper/energy-model-helper.cc View 8 9 12 13 2 chunks +2 lines, -0 lines 0 comments Download
M src/contrib/energy/helper/energy-source-container.cc View 9 12 13 2 chunks +9 lines, -1 line 0 comments Download
A src/contrib/energy/helper/rv-battery-model-helper.h View 1 chunk +50 lines, -0 lines 0 comments Download
A src/contrib/energy/helper/rv-battery-model-helper.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M src/contrib/energy/helper/wifi-radio-energy-model-helper.cc View 9 12 13 14 15 1 chunk +3 lines, -8 lines 0 comments Download
M src/contrib/energy/model/basic-energy-source.h View 8 9 12 13 2 chunks +3 lines, -14 lines 0 comments Download
M src/contrib/energy/model/basic-energy-source.cc View 8 11 12 13 3 chunks +3 lines, -29 lines 0 comments Download
M src/contrib/energy/model/device-energy-model.h View 8 9 12 13 1 chunk +0 lines, -14 lines 0 comments Download
M src/contrib/energy/model/energy-source.h View 8 9 12 13 3 chunks +18 lines, -17 lines 0 comments Download
M src/contrib/energy/model/energy-source.cc View 8 9 11 12 13 4 chunks +29 lines, -3 lines 0 comments Download
A src/contrib/energy/model/rv-battery-model.h View 15 1 chunk +259 lines, -0 lines 0 comments Download
A src/contrib/energy/model/rv-battery-model.cc View 15 1 chunk +367 lines, -0 lines 0 comments Download
M src/contrib/energy/model/wifi-radio-energy-model.h View 9 12 13 6 chunks +109 lines, -59 lines 0 comments Download
M src/contrib/energy/model/wifi-radio-energy-model.cc View 9 12 13 12 chunks +201 lines, -110 lines 0 comments Download
M src/contrib/energy/test/basic-energy-model-test.cc View 8 9 10 11 12 13 14 15 10 chunks +25 lines, -23 lines 0 comments Download
A src/contrib/energy/test/rv-battery-model-test.cc View 15 1 chunk +906 lines, -0 lines 0 comments Download
M src/contrib/energy/wscript View 8 9 12 13 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23
Mathieu Lacage
overall, it looks pretty good. My main concern is in the EnergyDeviceModel helper class: it ...
11 years, 3 months ago (2010-04-30 06:52:51 UTC) #1
(Tony) He Wu
http://codereview.appspot.com/1008043/diff/1/7 File src/devices/energy-model/device-energy-model.h (right): http://codereview.appspot.com/1008043/diff/1/7#newcode62 src/devices/energy-model/device-energy-model.h:62: protected: On 2010/04/30 06:52:51, Mathieu Lacage wrote: > would ...
11 years, 3 months ago (2010-04-30 23:45:45 UTC) #2
Mathieu Lacage
nothing to add to the minor comments below. http://codereview.appspot.com/1008043/diff/8001/9008 File src/devices/energy-model/energy-source.h (right): http://codereview.appspot.com/1008043/diff/8001/9008#newcode87 src/devices/energy-model/energy-source.h:87: * ...
11 years, 2 months ago (2010-05-04 09:19:59 UTC) #3
Tom Henderson
I just had minor comments; looks good. http://codereview.appspot.com/1008043/diff/1/18 File src/helper/radio-energy-helper.h (right): http://codereview.appspot.com/1008043/diff/1/18#newcode40 src/helper/radio-energy-helper.h:40: * Construct ...
11 years, 2 months ago (2010-05-04 20:35:36 UTC) #4
(Tony) He Wu
http://codereview.appspot.com/1008043/diff/8001/9008 File src/devices/energy-model/energy-source.h (right): http://codereview.appspot.com/1008043/diff/8001/9008#newcode87 src/devices/energy-model/energy-source.h:87: * \return Energy fraction = remaining energy / initial ...
11 years, 2 months ago (2010-05-05 17:21:56 UTC) #5
(Tony) He Wu
Patch set 3 is based on comments from all previous reviews. http://codereview.appspot.com/1008043/diff/8001/9008 File src/devices/energy-model/energy-source.h (right): ...
11 years, 2 months ago (2010-05-05 23:31:17 UTC) #6
(Tony) He Wu
Patch set 4 highlights: 1. Add unit test suite (devices-basic-energy-model) for BasicEnergySource and BasicRadioEnergyModel. 2. ...
11 years, 2 months ago (2010-05-07 22:06:39 UTC) #7
Tom Henderson
On 2010/05/07 22:06:39, (Tony) He Wu wrote: > Patch set 4 highlights: > > 1. ...
11 years, 1 month ago (2010-06-14 04:35:17 UTC) #8
(Tony) He Wu
On 2010/06/14 04:35:17, Tom Henderson wrote: > The main comment I have after reviewing tonight ...
11 years, 1 month ago (2010-06-14 22:59:51 UTC) #9
Tom Henderson
On 2010/06/14 22:59:51, (Tony) He Wu wrote: > On 2010/06/14 04:35:17, Tom Henderson wrote: > ...
11 years ago (2010-07-02 23:20:23 UTC) #10
(Tony) He Wu
On 2010/07/02 23:20:23, Tom Henderson wrote: > > After some discussion with you today, the ...
11 years ago (2010-07-03 02:35:31 UTC) #11
(Tony) He Wu
Hi, Highlight for patch set 9: 1. Remove RadioEnergyModel. A parent class for all radio ...
11 years ago (2010-07-13 02:27:09 UTC) #12
Tom Henderson
On 2010/07/13 02:27:09, (Tony) He Wu wrote: > Hi, > > Highlight for patch set ...
11 years ago (2010-07-13 04:14:46 UTC) #13
(Tony) He Wu
On 2010/07/13 04:14:46, Tom Henderson wrote: > Tony, it looks like the above patchset does ...
11 years ago (2010-07-13 05:45:13 UTC) #14
(Tony) He Wu
Hi All, Highlights for patch set 10: 1. Modify YansWifiPhy to support energy model. 2. ...
11 years ago (2010-07-14 00:32:00 UTC) #15
(Tony) He Wu
Hi All, Highlights of patch set 12: EnergySource: 1. Add new interfaces (using current, or ...
10 years, 11 months ago (2010-08-07 03:03:19 UTC) #16
(Tony) He Wu
Hi, Highlights of patch set 14. 1. Add callback to WifiPhy to support energy model. ...
10 years, 9 months ago (2010-10-07 00:39:39 UTC) #17
(Tony) He Wu
Hi All, Highlight of patch set 15: Add Rakhmatov-Vrudhula non-linear battery model. The model is ...
10 years, 9 months ago (2010-10-19 01:08:17 UTC) #18
Mathieu Lacage
these are really minor comments. I looked again at the energy model code in src/contrib/energy. ...
10 years, 9 months ago (2010-10-19 11:56:07 UTC) #19
(Tony) He Wu
On 2010/10/19 11:56:07, Mathieu Lacage wrote: > 1) What is the purpose of DeviceEnergyModel::Set/GetNode ? ...
10 years, 9 months ago (2010-10-19 18:44:16 UTC) #20
Mathieu Lacage
On Tue, Oct 19, 2010 at 20:44, <mdzzzz@gmail.com> wrote: > Right now DeviceEnergyModel::Set/GetNode are used ...
10 years, 9 months ago (2010-10-20 08:21:21 UTC) #21
Nicola Baldo
Hi Tony, I reviewed your code as far as the wifi modifications are concerned. I ...
10 years, 9 months ago (2010-10-21 13:51:47 UTC) #22
(Tony) He Wu
10 years, 9 months ago (2010-10-22 06:44:53 UTC) #23
Hi All,

Highlights of patch set 16:

1. Remove all modification to Wifi classes (WifiPhy and YansWifiPhy). Introduced
WifiRadioEnergyModelPhyListener to bridge between WifiPhy and
WifiRadioEnergyModel. Thanks to Nicola's comment.
2. Various changes according to Mathieu's comment.

Thanks,
Tony
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b