Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(581)

Issue 10069045: Make ibus-config tests side effect free (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Daiki Ueno
Modified:
12 years, 7 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Make ibus-config tests side effect free Previously we assumed that test cases are executed in the order of registration. This is no longer true after glib change 89aa9dbd which fixed test case grouping. Clear the default match rule in each test case to avoid side effect. BUG= Committed: c9ba5e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/tests/ibus-config.c View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4
Daiki Ueno
12 years, 8 months ago (2013-06-07 07:05:31 UTC) #1
Daiki Ueno
On 2013/06/07 07:05:31, Daiki Ueno wrote: Without this, ibus-config test fails with glib 2.36 as ...
12 years, 7 months ago (2013-06-13 02:10:19 UTC) #2
Peng
lgtm
12 years, 7 months ago (2013-06-13 12:16:17 UTC) #3
Daiki Ueno
12 years, 7 months ago (2013-06-14 02:01:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as rc9ba5e1 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b