Issue 100490046: Fix problem which was created by "fixing" Issue 462

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 100490046: Fix problem which was created by "fixing" Issue 462 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by peleyal

Modified:
10 years, 5 months ago

Reviewers:
class

CC:
google-api-dotnet-client_googlegroups.com

Base URL:
https://google-api-dotnet-client.googlecode.com/hg/

Visibility:
Public.

More Reviews

Description

Fix problem which was created by "fixing" Issue 462 I messed up in https://codereview.appspot.com/97380043/ - It's NOT compatible change! This change is eventually what is offered in https://code.google.com/p/google-api-dotnet-client/issues/detail?id=462 - Suggestion 1.

Patch Set 1 #

Patch Set 2 : minor #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	Src/GoogleApis.Auth.DotNet4/OAuth2/GoogleWebAuthorizationBroker.cs	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
	M	Src/GoogleApis.DotNet4/Apis/Util/Store/FileDataStore.cs	View	1	1 chunk	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2014/05/16 22:03:13, peleyal wrote:

LGTM.

Expand All Messages | Collapse All Messages