Issue 1004043: code review 1004043: net: add Pipe

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1004043: code review 1004043: net: add Pipe (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by rsc

Modified:
14 years, 10 months ago

Reviewers:
cw

CC:
r, golang-dev

Visibility:
Public.

Description

net: add Pipe

Patch Set 1 #

Patch Set 2 : code review 1004043: net: add Pipe #

Patch Set 3 : code review 1004043: net: add Pipe #

Total comments: 1

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -0 lines)			Patch
M	src/pkg/net/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/net/pipe.go	View	1	1 chunk	+62 lines, -0 lines	1 comment	Download
A	src/pkg/net/pipe_test.go	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-04-26 17:24:07 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=661e4f07ad8d *** net: add Pipe R=r CC=golang-dev http://codereview.appspot.com/1004043

14 years, 10 months ago (2010-04-26 17:36:08 UTC) #3

14 years, 10 months ago (2010-04-26 18:31:00 UTC) #4

http://codereview.appspot.com/1004043/diff/7001/8002
File src/pkg/net/pipe.go (right):

http://codereview.appspot.com/1004043/diff/7001/8002#newcode8
src/pkg/net/pipe.go:8: // Pipe creates a synchronous, in-memory, full duplex
pipe's historically aren't full duplex

maybe this should be called a StevensTube?

Expand All Messages | Collapse All Messages