Issue 6447084: [http issue 133] Android project improvements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6447084: [http issue 133] Android project improvements (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by yanivi

Modified:
11 years, 8 months ago

Reviewers:
rmistry

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Description

[http issue 133] Android project improvements [http issue 108] Android test for AndroidJsonFactory

Patch Set 1 #

Patch Set 2 : minor improvements #

Patch Set 3 : minor #

Patch Set 4 : revert the minor change #

Patch Set 5 : [http Issue 108] Android test for AndroidJsonFactory #

Patch Set 6 : minor #

Patch Set 7 : minor #

Patch Set 8 : fixed patch #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1791 lines, -9 lines)			Patch
A	google-http-client-android-test/.classpath	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
A	google-http-client-android-test/.project	View	1 2 3 4	1 chunk	+24 lines, -0 lines	0 comments	Download
A	google-http-client-android-test/AndroidManifest.xml	View	1 2 3 4	1 chunk	+17 lines, -0 lines	0 comments	Download
A	google-http-client-android-test/pom.xml	View	1 2 3 4 5 6 7	1 chunk	+117 lines, -0 lines	0 comments	Download
A	google-http-client-android-test/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonFactoryTest.java	View	1 2 3 4 5 6 7	1 chunk	+65 lines, -0 lines	0 comments	Download
A	google-http-client-android-test/src/main/java/com/google/api/client/extensions/android/json/FakeTest.java	View	1 2 3 4 5 6 7	1 chunk	+31 lines, -0 lines	0 comments	Download
A	google-http-client-android-test/src/main/java/com/google/api/client/extensions/android/json/package-info.java	View	1 2 3 4 5 6 7	1 chunk	+22 lines, -0 lines	0 comments	Download
A	google-http-client-android/.classpath	View	3	1 chunk	+7 lines, -0 lines	0 comments	Download
A	google-http-client-android/.project	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	google-http-client-android/.settings/org.eclipse.jdt.core.prefs	View	1	1 chunk	+380 lines, -0 lines	0 comments	Download
A	google-http-client-android/.settings/org.eclipse.jdt.ui.prefs	View		1 chunk	+120 lines, -0 lines	0 comments	Download
A	google-http-client-android/AndroidManifest.xml	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	google-http-client-android/pom.xml	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download
A	google-http-client-android/src/main/java/com/google/api/client/extensions/android/AndroidUtils.java	View		1 chunk	+52 lines, -0 lines	0 comments	Download
A	google-http-client-android/src/main/java/com/google/api/client/extensions/android/http/AndroidHttp.java	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download
A	google-http-client-android/src/main/java/com/google/api/client/extensions/android/http/package-info.java	View		1 chunk	+27 lines, -0 lines	0 comments	Download
A	google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonFactory.java	View		1 chunk	+94 lines, -0 lines	0 comments	Download
A	google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonGenerator.java	View		1 chunk	+194 lines, -0 lines	0 comments	Download
A	google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonParser.java	View		1 chunk	+244 lines, -0 lines	0 comments	Download
A	google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/package-info.java	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	google-http-client-android/src/main/java/com/google/api/client/extensions/android/package-info.java	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	google-http-client-android2/src/main/java/com/google/api/client/extensions/android2/AndroidHttp.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	google-http-client-android2/src/main/java/com/google/api/client/extensions/android2/package-info.java	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	google-http-client-android3/src/main/java/com/google/api/client/extensions/android3/json/AndroidJsonFactory.java	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	google-http-client-android3/src/main/java/com/google/api/client/extensions/android3/json/AndroidJsonGenerator.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	google-http-client-android3/src/main/java/com/google/api/client/extensions/android3/json/AndroidJsonParser.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	google-http-client-android3/src/main/java/com/google/api/client/extensions/android3/json/package-info.java	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	google-http-client-assembly/.classpath	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	google-http-client-assembly/assembly.xml	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	google-http-client-assembly/dependencies/android-dependencies.html	View		1 chunk	+99 lines, -0 lines	0 comments	Download
M	google-http-client-assembly/pom.xml	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	google-http-client-assembly/proguard-google-http-client.txt	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	google-http-client-assembly/readme.html	View		3 chunks	+28 lines, -7 lines	0 comments	Download
M	jdiff.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pom.xml	View	1 2 3 4 5 6 7	4 chunks	+13 lines, -1 line	0 comments	Download
M	release.html	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

yanivi

On 2012/08/03 19:47:23, rmistry wrote: > LGTM Please let me know when you are ready ...

11 years, 9 months ago (2012-08-03 20:30:47 UTC) #3

yanivi

I'm going to treat this changeset as blocked by: http://codereview.appspot.com/6454101/ google-http-client-test

11 years, 8 months ago (2012-08-15 17:45:21 UTC) #5

LGTM

Expand All Messages | Collapse All Messages