google-http-client-test

Fix for http://code.google.com/p/google-http-java-client/issues/detail?id=149 : Create google-http-client-test artifact.

[yanivi, 2012-08-08 14:52:21]

I don't have time to look at it in any detail right now.  One concern I have is
that unlike all of our other projects, ideally I don't want this project to be
published externally as a Maven artifact.  It should be just something we use as
a helper for our tests.  Can you please figure out if your changeset
accomplishes this or not?

http://codereview.appspot.com/6454101/diff/4001/google-http-client-test/src/m...
File
google-http-client-test/src/main/java/com/google/api/client/testing/json/package-info.java
(right):

http://codereview.appspot.com/6454101/diff/4001/google-http-client-test/src/m...
google-http-client-test/src/main/java/com/google/api/client/testing/json/package-info.java:23:
* @since 1.11
please remove @since (see other comment)

[rmistry, 2012-08-09 14:53:44]

http://codereview.appspot.com/6454101/diff/4001/google-http-client-test/src/m...
File
google-http-client-test/src/main/java/com/google/api/client/testing/json/package-info.java
(right):

http://codereview.appspot.com/6454101/diff/4001/google-http-client-test/src/m...
google-http-client-test/src/main/java/com/google/api/client/testing/json/package-info.java:23:
* @since 1.11
On 2012/08/08 14:52:21, yanivi wrote:
> please remove @since (see other comment)

Done.

[rmistry, 2012-08-09 14:54:12]

On 2012/08/08 14:52:21, yanivi wrote:
> I don't have time to look at it in any detail right now.  One concern I have
is
> that unlike all of our other projects, ideally I don't want this project to be
> published externally as a Maven artifact.  It should be just something we use
as
> a helper for our tests.  Can you please figure out if your changeset
> accomplishes this or not?


I ran 'mvn deploy' and it outputted-

[INFO] Reactor Build Order:
[INFO] 
[INFO] Parent for the Google HTTP Client Library for Java
[INFO] Google HTTP Client Library for Java
[INFO] Google App Engine extensions to the Google HTTP Client Library for Java.
[INFO] Android Eclair (SDK 2.1) platform extensions to the Google HTTP Client
Library for Java.
[INFO] Android Honeycomb (SDK 3.0) platform extensions to the Google HTTP Client
Library for Java.
[INFO] Protocol Buffer extensions to the Google HTTP Client Library for Java.
[INFO] GSON extensions to the Google HTTP Client Library for Java.
[INFO] Jackson extensions to the Google HTTP Client Library for Java.
[INFO] Assembly for the Google HTTP Client Library for Java

There is no 'Shared classes used for testing of artifacts in the Google HTTP
Client Library for Java.'

I believe it works because google-http-client-test does not exist in
google-http-client-assembly/pom.xml

> 
>
http://codereview.appspot.com/6454101/diff/4001/google-http-client-test/src/m...
> File
>
google-http-client-test/src/main/java/com/google/api/client/testing/json/package-info.java
> (right):
> 
>
http://codereview.appspot.com/6454101/diff/4001/google-http-client-test/src/m...
>
google-http-client-test/src/main/java/com/google/api/client/testing/json/package-info.java:23:
> * @since 1.11
> please remove @since (see other comment)

[yanivi, 2012-08-15 17:15:29]

please hg pull -u

[rmistry, 2012-08-16 11:32:57]

On 2012/08/15 17:15:29, yanivi wrote:
> please hg pull -u

Done.

[yanivi, 2012-08-16 16:52:52]

LGTM